bootstrap.sh hardcodes LIBTOOLIZE to "glibtoolize" on Darwin systems, regardless of whether the user has set a value for that variable already. This patch makes sure the user-set value of LIBTOOLIZE always takes priority. (Not on every configuration is libtoolize renamed to glibtoolize; it depends how one installed their build environment.) In my opinion it would be even better to just let libtoolize happen as part of autoreconf, which would pick up any normal overrides that the user made, same as other autotools packages; but it looks like it was set up this way purposely, and I'm not aware of the reasons, so I went for the simple fix instead.
Created attachment 127940 [details] [review] Patch
(In reply to Philip Chimento from comment #0) > In my opinion it would be even better to just let libtoolize happen as part > of autoreconf, which would pick up any normal overrides that the user made, > same as other autotools packages; but it looks like it was set up this way > purposely, and I'm not aware of the reasons, so I went for the simple fix > instead. libtoolize already happens as part of autoreconf. The LIBTOOLIZE variable stuff existed before we replaced a direct libtoolize call with autoreconf in commit 5b0aaecb0b, so this stuff is probably just some old cruft that should have been removed. Would you like to make another patch?
Created attachment 127973 [details] [review] Patch OK, got it!
Thanks! I applied the patch to the "next" branch.
Thanks!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.