Bug 98885

Summary:	Add CMake option for OCL ICD compatibility
Product:	Beignet	Reporter:	Marek Szuba <Marek.Szuba>
Component:	Beignet	Assignee:	Xiuli Pan <xiuli.pan>
Status:	RESOLVED MOVED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Proposed patch Proposed patch

Description Marek Szuba 2016-11-28 11:24:02 UTC

Hello,

At present, Beignet build scripts automatically enable OCL ICD compatibility mode if the latter is found at the time of invoking CMake. This slightly complicates the generation of Beignet distribution packages (disclaimer: I am the maintainer of Beignet packages in Gentoo) because left as it is it makes the package behave differently depending on whether ocl-icd was present on the build host or not. Would it perhaps be possible to make OCL ICD detection conditional on a CMake option? If the default value of the option is ON this change will be transparent to users.

Comment 1 Marek Szuba 2016-11-28 11:26:01 UTC

Created attachment 128235 [details] [review]
Proposed patch

Attaching a proposed patch. As you can see, all that is needed is three extra lines in the main CMakeLists.txt.

Comment 2 Xiuli Pan 2016-12-01 02:56:45 UTC

Hi Marek,

Thanks for your patch for Beignet, all patches that will help your users is welcomed! Could you send a format-patch with git and some commit to our mail-list: beignet@lists.freedesktop.org, I will review the patch and the patch will then be merged into master. Feel free to send patch that may be help!

Thanks
Xiuli

Comment 3 Marek Szuba 2016-12-01 12:25:18 UTC

Done!

Comment 4 Xiuli Pan 2016-12-02 01:54:47 UTC

I did not receive the patch, could you try a again?
And you can CC me : xiuli.pan@intel.com

Thanks
Xiuli

Comment 5 Marek Szuba 2017-01-25 13:07:17 UTC

Created attachment 129138 [details] [review]
Proposed patch

Updated to apply against current master

Comment 6 GitLab Migration User 2018-10-12 21:25:45 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/beignet/beignet/issues/52.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.