At present, Beignet build scripts automatically enable OCL ICD compatibility mode if the latter is found at the time of invoking CMake. This slightly complicates the generation of Beignet distribution packages (disclaimer: I am the maintainer of Beignet packages in Gentoo) because left as it is it makes the package behave differently depending on whether ocl-icd was present on the build host or not. Would it perhaps be possible to make OCL ICD detection conditional on a CMake option? If the default value of the option is ON this change will be transparent to users.
Created attachment 128235 [details] [review]
Attaching a proposed patch. As you can see, all that is needed is three extra lines in the main CMakeLists.txt.
Thanks for your patch for Beignet, all patches that will help your users is welcomed! Could you send a format-patch with git and some commit to our mail-list: email@example.com, I will review the patch and the patch will then be merged into master. Feel free to send patch that may be help!
I did not receive the patch, could you try a again?
And you can CC me : firstname.lastname@example.org
Created attachment 129138 [details] [review]
Updated to apply against current master
-- GitLab Migration Automatic Message --
This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/beignet/beignet/issues/52.