Bug 100223 - marshal_generated.c:38:10: fatal error: 'X11/Xlib-xcb.h' file not found
Summary: marshal_generated.c:38:10: fatal error: 'X11/Xlib-xcb.h' file not found
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Mac OS X (All)
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords: bisected, regression
Depends on:
Blocks:
 
Reported: 2017-03-16 05:44 UTC by Vinson Lee
Modified: 2017-03-17 01:58 UTC (History)
5 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vinson Lee 2017-03-16 05:44:43 UTC
mesa: 04a9ca2700742def92ff5dfdf487f4724c9c4441 (master 17.1.0-devel)

  CC       main/marshal_generated.lo
main/marshal_generated.c:38:10: fatal error: 'X11/Xlib-xcb.h' file not found
#include <X11/Xlib-xcb.h>
         ^
Comment 1 Vinson Lee 2017-03-16 07:46:15 UTC
efd63e234a805edc8b1c9962610d70d3a62f7c18 is the first bad commit
commit efd63e234a805edc8b1c9962610d70d3a62f7c18
Author: Eric Anholt <eric@anholt.net>
Date:   Wed Jan 2 14:12:04 2013 -0800

    mesa: Connect the generated GL command marshalling code to the build.
    
    v2: Rebase on the Begin/End changes, and just disable this feature on
        non-GL-core.
    v3: (Timothy Arceri) enable for non-GL-core contexts. Remove
        unrelated safe_mul() hunk. while loop style fix.
    
    Acked-by: Timothy Arceri <tarceri@itsqueeze.com>
    Acked-by: Marek Olšák <maraeo@gmail.com>
    Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de>
    Tested-by: Mike Lothian <mike@fireburn.co.uk>

:040000 040000 0600192d4c3a60aa537f8a78f426d2a6ed8549ea 6e790d8d7d312c1a10a3b8f1ada2fcdc43810a89 M	src
bisect run success
Comment 2 Tapani Pälli 2017-03-16 09:16:29 UTC
FYI we are getting this error also on Android where 'X11/Xlib-xcb.h' does not exist
Comment 3 Tapani Pälli 2017-03-16 09:29:49 UTC
IMO there should be a check if X11 exists or maybe removal of include if this code does not utilize Xlib/Xcb?
Comment 4 Timothy Arceri 2017-03-17 01:58:52 UTC
Should be fixed by:

commit c81c563fbbb06b6f1dd06ed62f252ed28d45be5a
Author: Emil Velikov <emil.velikov@collabora.com>
Date:   Thu Mar 16 11:05:23 2017 +0000

    mapi: remove Xlib/xcb include in gl_marshal.py
    
    The only use of the header is to provide the _X_INLINE macro. We already
    require (and provide where needed) 'inline', plus it's used in the file
    already.
    
    So replace the macro and drop the include. This fixes the build on
    platforms which lack the header - from X-less Linuxes to Androids.
    
    Fixes: 05dd4a1104e ("glapi: Generate GL API marshalling code from the XML.")
    Reported-by: Vinson Lee <vlee@freedesktop.org>
    Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
    Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100223
    Signed-off-by: Emil Velikov <emil.velikov@collabora.com>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct.