Created attachment 130298 [details] [review]
data: Add gnome-shell's weather integration to the whitelist

gnome-shell now uses Geoclue to show weather information in the calendar
drop-down. While it can easily bypass the authorization dialog (being
the agent itself), the location indicator loses its usefulness when
permanently visible, so add it to the other system components in the
whitelist.

Didn't we say it'd be better if this functionality piggy-backed onto gnome-weather's configuration?

Ideally, gnome-shell could check whether gnome-weather is authorised, if it is, then use its .desktop ID, if not, then display something to launch gnome-weather and show how to solve the problem there.

This should be possible using the Flatpak permission store.

(In reply to Bastien Nocera from comment #2)
> Didn't we say it'd be better if this functionality piggy-backed onto
> gnome-weather's configuration?
> 
> Ideally, gnome-shell could check whether gnome-weather is authorised

I plan to do this for .1, but this doesn't solve the issue that we now have a permanently visible location indicator when the weather integration is active. As the idea behind the indicator is to allow users to spot suspicious uses of location services, it becomes pointless when always shown anyway.

(Of course the whitelist defeats that in a way, as any app could just identify itself as 'gnome-datetime-panel' and get a free pass)


> then use its .desktop ID

No, I don't think we want the exact same behavior for weather and gnome-shell, see above. My idea is that we'd use our own ID as we do know and be whitelisted as a system component. Then we'd determine the location like this:

 1. use geoclue if weather is configured to use auto-locations AND
    is authorized by the permission store
 2. use the most recent "manual" location from weather if there are any
 3. don't use any location, show something like "Set up weather forecasts"
    instead

(In reply to Florian Müllner from comment #3)
> (In reply to Bastien Nocera from comment #2)
> > Didn't we say it'd be better if this functionality piggy-backed onto
> > gnome-weather's configuration?
> > 
> > Ideally, gnome-shell could check whether gnome-weather is authorised
> 
> I plan to do this for .1, but this doesn't solve the issue that we now have
> a permanently visible location indicator when the weather integration is
> active. As the idea behind the indicator is to allow users to spot
> suspicious uses of location services, it becomes pointless when always shown
> anyway.
> 
> (Of course the whitelist defeats that in a way, as any app could just
> identify itself as 'gnome-datetime-panel' and get a free pass)

Non-sandboxed apps can lie and there's anything we can do about that but I agree that we shouldn't do that on purpose.

Comment on attachment 130298 [details] [review]
data: Add gnome-shell's weather integration to the whitelist

Pushed with shortlog shortened to fit 50 chars (as it should :)).