Bug 100350 - EDID-Decode does not allow spaces in 'Monitor Name' detailed block
Summary: EDID-Decode does not allow spaces in 'Monitor Name' detailed block
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/edid-decode (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 100349 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-03-23 02:23 UTC by Simon
Modified: 2018-08-12 20:45 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch to fix (1.39 KB, patch)
2017-03-23 02:23 UTC, Simon
no flags Details | Splinter Review
sample edid with spaces (256 bytes, application/octet-stream)
2017-03-23 02:25 UTC, Simon
no flags Details

Description Simon 2017-03-23 02:23:13 UTC
edid-decode does not allow spaces, it is incorrectly reporting the name and throwing an error.

edid-decode:
--
descriptor 4:    00 00 00 fc 00 53 4d 41 52 54 20 49 46 50 0a 20 20 20
...
Monitor name: SMART
...
Detailed block string not properly terminated
--

parse-edid:
--
Section "Monitor"
	Identifier "SMART IFP"
	ModelName "SMART IFP"
--

After attached patch edid-decode behaves correctly.
Simon.
Comment 1 Simon 2017-03-23 02:23:53 UTC
Created attachment 130390 [details] [review]
patch to fix
Comment 2 Simon 2017-03-23 02:25:04 UTC
Created attachment 130391 [details]
sample edid with spaces
Comment 3 Simon 2017-03-23 17:08:54 UTC
*** Bug 100349 has been marked as a duplicate of this bug. ***
Comment 4 Simon 2017-03-24 16:15:58 UTC
Related Bug 93777.
Comment 5 Tj 2018-03-02 20:50:34 UTC
I found and fixed this independently in Ubuntu before checking upstream and finding this report.

It has been fixed in

commit 57c73067385e0bd29d0a67fd73db4ebecc8fb084
Author: Adam Jackson <ajax@redhat.com>
Date:   Tue Mar 28 11:21:36 2017 -0400

    Fix valid termination check
Comment 6 Simon 2018-03-02 21:19:19 UTC
Hi Adam,
Don't know what I could have done to make my patch easier to find... ;-)

Do you have a link to your patch, so that it can be validated?
Simon.
Comment 7 Alan Coopersmith 2018-08-12 20:45:07 UTC
https://git.linuxtv.org/edid-decode.git/commit/edid-decode.c?id=57c73067385e0bd29d0a67fd73db4ebecc8fb084
is the fix that was applied.

Thanks for the report and sample fix, sorry that no one was watching
bugzilla at the time.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.