Bug 100551 - Add support for SW_RFKILL_ALL
Summary: Add support for SW_RFKILL_ALL
Alias: None
Product: Wayland
Classification: Unclassified
Component: libinput (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Peter Hutterer
QA Contact:
URL: https://bugzilla.gnome.org/show_bug.c...
Depends on:
Blocks: 101008
  Show dependency treegraph
Reported: 2017-04-04 09:46 UTC by Benjamin Berg
Modified: 2017-08-23 22:17 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Description Benjamin Berg 2017-04-04 09:46:15 UTC
For full handling of rfkill in GNOME we need the switch state for SW_RFKILL_ALL to be available. It is fine if this information is not available on X11 as we can disable the handling of rfkill in GNOME in that case.

See https://bugzilla.gnome.org/show_bug.cgi?id=760517 for some more information on the rfkill issue.
Comment 1 Peter Hutterer 2017-04-21 00:49:47 UTC
What device does this event come from? Is it a separate kernel device that handles this or is it part of a keyboard? If the former, it's easy to integrate with a few lines of code, the latter would require some extra work.
Comment 3 Peter Hutterer 2017-04-28 00:32:19 UTC
Note that since this introduces new API/ABI into libinput I'll need at least a rev-by tag from you and ideally an implementation that shows that the approach is actually feasable/good enough. once it's shipped, it cannot be changed.
Comment 4 Peter Hutterer 2017-05-16 23:37:35 UTC
I'll keep the branch here for easier testing, but I'll still need an ACK for the proposed changes before I make this part of an API set in stone:
Comment 5 Peter Hutterer 2017-08-17 22:48:56 UTC
Benjamin, you got an update for me here? I notice the GNOME bug is closed, it's a bit unclear to me if you still want the switch state
Comment 6 Benjamin Berg 2017-08-23 11:58:41 UTC
Sorry, should have chatted about that at GUADEC.

So, the situation is that we effectively don't seem to have any hardware where we actually need this (i.e. it is handled in firmware and/or the driver). That said, reporting it could still improve the user experience by showing an OSD.

Other than that, I simply do not feel confident in being able ACK it as I do not currently know enough about Wayland input handling.
Comment 7 Peter Hutterer 2017-08-23 22:17:34 UTC
Let's close this for now. It's all nice to have theoretical use-cases for it but until we have a request for a specific case it's better to leave things as-is. Otherwise we end up fixing the wrong problem and painting ourselves into a corner.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.