Bug 100621 - [SKL] isl_surface_state.c asserts in DOOM
Summary: [SKL] isl_surface_state.c asserts in DOOM
Status: RESOLVED MOVED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Vulkan/intel (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Intel 3D Bugs Mailing List
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-08 17:27 UTC by Grazvydas Ignotas
Modified: 2019-09-18 19:48 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Grazvydas Ignotas 2017-04-08 17:27:33 UTC
DOOM is hitting some isl_surface_state.c asserts since when they have been added:

mon\DOOM\DOOMx64vk.exe: isl/isl_surface_state.c:488: isl_gen9_surf_fill_state_s: Assertion `info->view->swizzle.b == ISL_CHANNEL_SELECT_RED || info->view->swizzle.b == ISL_CHANNEL_SELECT_GREEN || info->view->swizzle.b == ISL_CHANNEL_SELECT_BLUE' failed.
mon\DOOM\DOOMx64vk.exe: isl/isl_surface_state.c:485: isl_gen9_surf_fill_state_s: Assertion `info->view->swizzle.g == ISL_CHANNEL_SELECT_RED || info->view->swizzle.g == ISL_CHANNEL_SELECT_GREEN || info->view->swizzle.g == ISL_CHANNEL_SELECT_BLUE' failed.

Printing out the values shows that .g and/or .b are sometimes 0.
From some limited testing, no rendering problems noticed in release build (or with those asserts commented out).
Comment 1 Jason Ekstrand 2017-04-08 17:56:47 UTC
What is the color format of said images?  If it's just a red image, I could see them setting invalid swizzle values.
Comment 2 Grazvydas Ignotas 2017-04-08 20:03:35 UTC
If you mean info->view->format, debug prints yielded
fmt 208 swizzle.b 0 // ISL_FORMAT_R16G16_FLOAT?
fmt 270 swizzle.b 0 // ISL_FORMAT_R16_FLOAT?
fmt 270 swizzle.g 0 // ISL_FORMAT_R16_FLOAT?
fmt 320 swizzle.b 0 // ISL_FORMAT_R8_UNORM?
fmt 320 swizzle.g 0 // ISL_FORMAT_R8_UNORM?
Comment 3 Jason Ekstrand 2017-04-08 22:40:17 UTC
I believe what its doing is technically against the spec but I could see an app thinking it's OK.  I'll think on it a bit more.  For now, just run a release build. :-)
Comment 4 GitLab Migration User 2019-09-18 19:48:24 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/829.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.