Bug 100673 - Tonga agd5f drm-next-4.12-wip xorg segfault on startx
Summary: Tonga agd5f drm-next-4.12-wip xorg segfault on startx
Status: RESOLVED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/AMDgpu (show other bugs)
Version: DRI git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-13 11:43 UTC by Andy Furniss
Modified: 2017-04-21 14:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
xorg log with segfault (16.83 KB, text/plain)
2017-04-13 11:43 UTC, Andy Furniss
no flags Details
dmesg with lots of warnings on startx (older kernel) (228.65 KB, text/plain)
2017-04-13 11:44 UTC, Andy Furniss
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Furniss 2017-04-13 11:43:05 UTC
Created attachment 130829 [details]
xorg log with segfault

With current agd5f  drm-next-4.12-wip I get a segfault on startx (xserver 1.19.3, git ddx,mesa,llvm. Log attached.

On the previous incarnation of the same kernel I can startx, but there are a lot of warnings in dmesg every time the screen is turned on - ie. startx or coming out of dpms. dmesg attached.

Don't know when I'll get time to bisect, so just getting these reported now.
Comment 1 Andy Furniss 2017-04-13 11:44:13 UTC
Created attachment 130830 [details]
dmesg with lots of warnings on startx (older kernel)
Comment 2 Alex Deucher 2017-04-13 13:49:02 UTC
(In reply to Andy Furniss from comment #1)
> Created attachment 130830 [details]
> dmesg with lots of warnings on startx (older kernel)

This was fixed here:
https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.12-wip&id=53552d5df6694f68f276b2e86f8162d0ef7cad93
Comment 3 Andres Rodriguez 2017-04-13 19:56:20 UTC
Reverting the following commit fixes this branch for me:
eb8eb02 drm: Drop modeset_lock_all from the getproperty ioctl

Let me check if I can make a quick fix for it.
Comment 4 Alex Deucher 2017-04-13 20:33:52 UTC
Should be fixed by:

commit 8cb68c83ab99a474ae847602f0c514d0fe17cc82
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Mon Apr 10 13:54:45 2017 +0200

    drm: Fix get_property logic fumble

    Yet again I've proven that I can't negate conditions :(

    Testcase: igt/kms_properties/get_property-sanity
    Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Reviewed-by: Sean Paul <seanpaul@chromium.org>
    Fixes: eb8eb02ed850 ("drm: Drop modeset_lock_all from the getproperty ioctl")
Comment 5 Andy Furniss 2017-04-13 22:04:32 UTC
(In reply to Alex Deucher from comment #4)
> Should be fixed by:
> 
> commit 8cb68c83ab99a474ae847602f0c514d0fe17cc82
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Mon Apr 10 13:54:45 2017 +0200
> 
>     drm: Fix get_property logic fumble
> 
>     Yet again I've proven that I can't negate conditions :(
> 
>     Testcase: igt/kms_properties/get_property-sanity
>     Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>     Reviewed-by: Sean Paul <seanpaul@chromium.org>
>     Fixes: eb8eb02ed850 ("drm: Drop modeset_lock_all from the getproperty
> ioctl")

Ok, but it doesn't seem to be anywhere in your tree.
Comment 6 Alex Deucher 2017-04-13 22:11:56 UTC
(In reply to Andy Furniss from comment #5)
> (In reply to Alex Deucher from comment #4)
> > Should be fixed by:
> > 
> > commit 8cb68c83ab99a474ae847602f0c514d0fe17cc82
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date:   Mon Apr 10 13:54:45 2017 +0200
> > 
> >     drm: Fix get_property logic fumble
> > 
> >     Yet again I've proven that I can't negate conditions :(
> > 
> >     Testcase: igt/kms_properties/get_property-sanity
> >     Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> >     Reviewed-by: Sean Paul <seanpaul@chromium.org>
> >     Fixes: eb8eb02ed850 ("drm: Drop modeset_lock_all from the getproperty
> > ioctl")
> 
> Ok, but it doesn't seem to be anywhere in your tree.

It hasn't been pulled into drm-next yet.
Comment 7 Alex Deucher 2017-04-21 14:54:17 UTC
Patch is in drm-next now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.