Bug 100717 - [CI][APL/GLK/SKL/KBL/HSW/BDW/BSW/BYT/CFL] pm_rpm@debugfs-read
Summary: [CI][APL/GLK/SKL/KBL/HSW/BDW/BSW/BYT/CFL] pm_rpm@debugfs-read
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: IGT (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: highest critical
Assignee: Chris Wilson
QA Contact:
URL:
Whiteboard: ReadyForDev
Keywords: bisected
Depends on:
Blocks:
 
Reported: 2017-04-18 22:08 UTC by maria guadalupe
Modified: 2017-09-07 07:48 UTC (History)
3 users (show)

See Also:
i915 platform: BDW, BSW/CHT, BXT, BYT, GLK, HSW, KBL, SKL
i915 features: power/Other


Attachments
dmesg.log (115.02 KB, text/plain)
2017-04-18 22:08 UTC, maria guadalupe
no flags Details

Description maria guadalupe 2017-04-18 22:08:16 UTC
Created attachment 130907 [details]
dmesg.log

this test "Remove igt@pm_rpm@debugfs-read" is failing over GLK with the next configuration. 

Software
======================================
kernel version              : 4.11.0-rc6-drm-tip-94416e8-guc-huc-glk+
architecture                : x86_64
os version                  : Ubuntu 16.10
os codename                 : yakkety
kernel driver               : i915
bios revision               : 41.51
bios release date           : 03/31/2017
ksc                         : 1.25

======================================
        Graphic drivers
======================================
modesetting                 : modesetting_drv.so
xorg-xserver                : 1.18.4
libdrm                      : 2.4.79
cairo                       : 1.15.5
xserver                     : X.Org X Server 1.18.4
intel-gpu-tools (tag)       : intel-gpu-tools-1.18-73-gd8b83aa
intel-gpu-tools (commit)    : d8b83aa

======================================
             Hardware
======================================
platform                  : Geminilake
motherboard model          : Geminilake
motherboard id             : GLKRVP1DDR4(05)
form factor                : Hand Held
manufacturer               : IntelCorp.
cpu family                 : Other
cpu family id              : 6
cpu information            : Genuine Intel(R) CPU @ 1.10GHz
gpu card                   : Intel Corporation Device 3184 (rev 01) (prog-if 00 [VGA controller])
memory ram                 : 7.64 GB
max memory ram             : 16 GB
xdpyinfo:  unable to open display ":0".
cpu thread                 : 4
cpu core                   : 4
cpu model                  : 122
hard drive                 : 223GiB (240GB)
current cd clock frequency : 316800 kHz
maximum cd clock frequency : 316800 kHz
displays connected         : HDMI-A-2

======================================
             Firmware
======================================
dmc fw loaded             : yes
dmc version               : 1.4

OUTPUT
======================================
./pm_rpm --r debugfs-read --debug
IGT-Version: 1.18-gd8b83aa (x86_64) (Linux: 4.11.0-rc6-drm-tip-94416e8-guc-huc-glk+ x86_64)
(pm_rpm:1465) drmtest-DEBUG: Test requirement passed: !(fd<0)
(pm_rpm:1465) igt-debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0'
(pm_rpm:1465) drmtest-DEBUG: Test requirement passed: drmSetMaster(fd) == 0
(pm_rpm:1465) igt-debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0'
(pm_rpm:1465) DEBUG: Test requirement passed: debugfs != -1
(pm_rpm:1465) igt-kms-DEBUG: VT: graphics mode set (mode was 0x0)
(pm_rpm:1465) igt-fb-DEBUG: igt_create_fb_with_bo_size(width=3840, height=2160, format=0x34325258, tiling=0x0, size=0)
(pm_rpm:1465) igt-fb-DEBUG: igt_create_fb_with_bo_size(handle=1, pitch=15360)
Runtime PM support: 1
PC8 residency support: 0
(pm_rpm:1465) DEBUG: Test requirement passed: has_runtime_pm
(pm_rpm:1465) igt-core-DEBUG: Starting subtest: debugfs-read
(pm_rpm:1465) igt-pm-CRITICAL: Test assertion failure function igt_get_runtime_pm_status, file igt_pm.c:322:
(pm_rpm:1465) igt-pm-CRITICAL: Failed assertion: false
(pm_rpm:1465) igt-pm-CRITICAL: Unknown status error

Stack trace:
  #0 [__igt_fail_assert+0x101]
  #1 [igt_get_runtime_pm_status+0x178]
  #2 [igt_wait_for_pm_status+0x66]
  #3 [main+0x1690]
  #4 [__libc_start_main+0xf1]
  #5 [_start+0x29]
  #6 [<unknown>+0x29]
Subtest debugfs-read failed.
**** DEBUG ****
(pm_rpm:1465) igt-pm-CRITICAL: Test assertion failure function igt_get_runtime_pm_status, file igt_pm.c:322:
(pm_rpm:1465) igt-pm-CRITICAL: Failed assertion: false
(pm_rpm:1465) igt-pm-CRITICAL: Unknown status error

****  END  ****
Subtest debugfs-read: FAIL (0.027s)
Comment 1 Marta Löfstedt 2017-05-08 06:51:41 UTC
This is failing for the i915_forcewake_user.
I talked with Ville and Imre about this, they claim that this has worked before. But, I have tested it failing on Ubuntu pre-build kernels 4.1, 4.4, 4.8, so it must have passed very long time ago.
Also note that:
 pm_rpm@sysfs-read 
fails for the same reason on all platforms while running extended list on CI farm2 in Espoo.
Comment 2 Marta Löfstedt 2017-05-08 09:33:10 UTC
Note that:

pm_rpm --run-subtest debugfs-forcewake-user

pass.
Comment 3 Marta Löfstedt 2017-05-08 10:00:07 UTC
Should the i915_forcewake_user really be tested in the debugfs-read subtest?
Comments suggest that we can't suspend while the forcewake is open we can't suspend, but the test checks that we actually will suspend.

Also, I tested to exclude the i915_forcewake_user from being opened. Then I hit a "new" issue while trying to open:  
/sys/kernel/debug/dri/0/crtc-2/crc/data

(pm_rpm:12571) CRITICAL: Test assertion failure function read_files_from_dir, file pm_rpm.c:874:
(pm_rpm:12571) CRITICAL: Failed assertion: rc == 0
(pm_rpm:12571) CRITICAL: Last errno: 9, Bad file descriptor
(pm_rpm:12571) CRITICAL: error: -1 != 0
Comment 4 Humberto Israel Perez Rodriguez 2017-05-17 19:14:46 UTC
Hi , the following test cases are failing on APL

Test cases :
=========================================
igt@pm_rpm@sysfs-read
igt@pm_rpm@debugfs-read


output :
==========================================
IGT-Version: 1.18-g93215b0 (x86_64) (Linux: 4.12.0-rc1-drm-tip-ww20-commit-713f8ec+ x86_64)
(pm_rpm:1409) drmtest-DEBUG: Test requirement passed: !(fd<0)
(pm_rpm:1409) igt-debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0'
(pm_rpm:1409) drmtest-DEBUG: Test requirement passed: drmSetMaster(fd) == 0
(pm_rpm:1409) igt-debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0'
(pm_rpm:1409) DEBUG: Test requirement passed: debugfs != -1
(pm_rpm:1409) igt-kms-DEBUG: VT: graphics mode set (mode was 0x0)
(pm_rpm:1409) igt-fb-DEBUG: igt_create_fb_with_bo_size(width=3840, height=2160, format=0x34325258, tiling=0x0, size=0)
(pm_rpm:1409) igt-fb-DEBUG: igt_create_fb_with_bo_size(handle=1, pitch=15360)
Runtime PM support: 1
PC8 residency support: 0
(pm_rpm:1409) DEBUG: Test requirement passed: has_runtime_pm
(pm_rpm:1409) igt-core-DEBUG: Starting subtest: debugfs-read
(pm_rpm:1409) CRITICAL: Test assertion failure function read_full_file, file pm_rpm.c:838:
(pm_rpm:1409) CRITICAL: Failed assertion: wait_for_suspended()
(pm_rpm:1409) CRITICAL: Last errno: 19, No such device
(pm_rpm:1409) CRITICAL: File: i915_forcewake_user
Stack trace:
  #0 [__igt_fail_assert+0x101]
  #1 [read_files_from_dir+0x24f]
  #2 [main+0x16a1]
  #3 [__libc_start_main+0xf1]
  #4 [_start+0x29]
  #5 [<unknown>+0x29]
Subtest debugfs-read failed.
**** DEBUG ****
(pm_rpm:1409) CRITICAL: Test assertion failure function read_full_file, file pm_rpm.c:838:
(pm_rpm:1409) CRITICAL: Failed assertion: wait_for_suspended()
(pm_rpm:1409) CRITICAL: Last errno: 19, No such device
(pm_rpm:1409) CRITICAL: File: i915_forcewake_user
****  END  ****
Subtest debugfs-read: FAIL (12.479s)
(pm_rpm:1409) igt-core-DEBUG: Exiting with status code 99
(pm_rpm:1409) igt-kms-DEBUG: VT: original mode 0x0 restored
(pm_rpm:1409) igt-debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0'


======================================
             Software
======================================
kernel version              : 4.12.0-rc1-drm-tip-ww20-commit-713f8ec+
architecture                : x86_64
os version                  : Ubuntu 16.10
os codename                 : yakkety
kernel driver               : i915
bios revision               : 5.6
bios release date           : 03/10/2017
ksc                         : 16.0

======================================
        Graphic drivers
======================================
Component: drm
    tag: libdrm-2.4.80-11-ga2fa2e0
    commit: a2fa2e08692483cf9f4d06caa6e0f0add59e3343

Component: cairo
    tag: 1.15.4-21-g9d44136
    commit: 9d44136ef8e2a1ad2c6631beb4bbdaeed7a2dad8

Component: intel-gpu-tools
    tag: intel-gpu-tools-1.18-173-g93215b0
    commit: 93215b00db06ba568c34a6cad194f4749bbfbc9d

Component: piglit
    tag: piglit-v1
    commit: 7352f4a98a23eae1201bfc4a0121d9c3a969d23f

======================================
             Hardware
======================================
motherboard model          : NUC6CAYS
motherboard id             : NUC6CAYB
form factor                : Desktop
manufacturer               : Intelcorporation
cpu family                 : Celeron
cpu family id              : 6
cpu information            : Intel(R) Celeron(R) CPU J3455 @ 1.50GHz
gpu card                   : Intel Corporation Device 5a85 (rev 0b) (prog-if 00 [VGA controller])
memory ram                 : 15.54 GB
cpu thread                 : 4
cpu core                   : 4
cpu model                  : 92
cpu stepping               : 9
signature                  : Type 0, Family 6, Model 92, Stepping 9
current cd clock frequency : 384000 kHz
maximum cd clock frequency : 624000 kHz
displays connected         : DP-1 DP-2

======================================
             Firmware
======================================
dmc fw loaded             : yes
dmc version               : 1.7
guc fw loaded             : NONE
guc version wanted        : 0.0
guc version found         : 0.0
Add Comment
Comment 5 Humberto Israel Perez Rodriguez 2017-05-19 20:30:52 UTC
same issue with SKL on lastest configuration


igt@pm_rpm@sysfs-read
igt@pm_rpm@debugfs-read

======================================
        Graphic drivers
======================================
Component: drm
    tag: libdrm-2.4.80-11-ga2fa2e0
    commit: a2fa2e08692483cf9f4d06caa6e0f0add59e3343

Component: cairo
    tag: 1.15.4-21-g9d44136
    commit: 9d44136ef8e2a1ad2c6631beb4bbdaeed7a2dad8

Component: intel-gpu-tools
    tag: intel-gpu-tools-1.18-173-g93215b0
    commit: 93215b00db06ba568c34a6cad194f4749bbfbc9d

Component: piglit
    tag: piglit-v1
    commit: 7352f4a98a23eae1201bfc4a0121d9c3a969d23f
Comment 6 Humberto Israel Perez Rodriguez 2017-05-24 22:40:01 UTC
same issue with KBL and latest configuration

test cases
============================================
igt@pm_rpm@sysfs-read
igt@pm_rpm@debugfs-read



Component: drm
    tag: libdrm-2.4.80-15-geeb51df
    commit: eeb51df3ced003515ba4a71492eeb86c145cb77e

Component: cairo
    tag: 1.15.4-21-g9d44136
    commit: 9d44136ef8e2a1ad2c6631beb4bbdaeed7a2dad8

Component: intel-gpu-tools
    tag: intel-gpu-tools-1.18-209-g26c266f
    commit: 26c266febe1fc97c46d25a33aaf6a1869a51c008

Component: piglit
    tag: piglit-v1
    commit: 9cc5b2169ab6eb8a6a09329836d8d884d4350eec


======================================
             Software
======================================
kernel version              : 4.12.0-rc2-drm-tip-ww21-commit-7808a0f+
architecture                : x86_64
os version                  : Ubuntu 16.10
os codename                 : yakkety
kernel driver               : i915
bios revision               : 5.6
bios release date           : 05/03/2017
ksc                         : 8.1

======================================
             Hardware
======================================
motherboard id             : NUC7i5BNB
form factor                : Desktop
cpu family                 : Core i5
cpu family id              : 6
cpu information            : Intel(R) Core(TM) i5-7260U CPU @ 2.20GHz
gpu card                   : Intel Corporation Device 5926 (rev 06) (prog-if 00 [VGA controller])
memory ram                 : 15.58 GB
max memory ram             : 32 GB
cpu thread                 : 4
cpu core                   : 2
cpu model                  : 142
cpu stepping               : 9
socket                     : Other
signature                  : Type 0, Family 6, Model 142, Stepping 9
hard drive                 : 447GiB (480GB)
current cd clock frequency : 337500 kHz
maximum cd clock frequency : 675000 kHz
displays connected         : DP-1 DP-2

======================================
             Firmware
======================================
dmc fw loaded             : yes
dmc version               : 1.1
guc fw loaded             : NONE
guc version wanted        : 0.0
guc version found         : 0.0
Comment 7 Humberto Israel Perez Rodriguez 2017-05-30 21:23:46 UTC
same issue on BDW with latest configuration

igt@pm_rpm@sysfs-read
igt@pm_rpm@pc8-residency
igt@pm_rpm@modeset-pc8-residency-stress
igt@pm_rpm@debugfs-read
igt@pm_rpm@gem-execbuf-stress-pc8



Component: drm
    tag: libdrm-2.4.80-18-gce9e3ba
    commit: ce9e3ba6e2cc65e1e9e6e05a5f326c4dd25ab2c4

Component: cairo
    tag: 1.15.4-22-g0fd0fd0
    commit: 0fd0fd0ae9ad8cfb177bb844091de98c0235917e

Component: intel-gpu-tools
    tag: intel-gpu-tools-1.18-211-g00ce341
    commit: 00ce341b95c718611689ded8ccec45086186c5b7

Component: piglit
    tag: piglit-v1
    commit: ebbb9c5dcc6a637884d54e06eb430a8c14993413

	
Kernel version
=========================================
commit 75397b60fe84eb5125a78a5ee304def86b761994
Author:     Chris Wilson <chris@chris-wilson.co.uk>
AuthorDate: Tue May 30 12:56:32 2017 +0100
Commit:     Chris Wilson <chris@chris-wilson.co.uk>
CommitDate: Tue May 30 12:56:32 2017 +0100

    drm-tip: 2017y-05m-30d-11h-55m-42s UTC integration manifest
Comment 8 Humberto Israel Perez Rodriguez 2017-06-01 00:32:09 UTC
same issue on BSW with latest configuration

igt@pm_rpm@debugfs-read


Component: drm
    tag: libdrm-2.4.80-18-gce9e3ba
    commit: ce9e3ba6e2cc65e1e9e6e05a5f326c4dd25ab2c4

Component: cairo
    tag: 1.15.4-22-g0fd0fd0
    commit: 0fd0fd0ae9ad8cfb177bb844091de98c0235917e

Component: intel-gpu-tools
    tag: intel-gpu-tools-1.18-211-g00ce341
    commit: 00ce341b95c718611689ded8ccec45086186c5b7

Component: piglit
    tag: piglit-v1
    commit: ebbb9c5dcc6a637884d54e06eb430a8c14993413

kernel
===================================================
commit 4aa1d46d3b24bbe545cdf7cbd407c18f5cd5e43d
Author:     Daniel Vetter <daniel.vetter@ffwll.ch>
AuthorDate: Wed May 31 10:59:05 2017 +0200
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Wed May 31 10:59:05 2017 +0200

    drm-tip: 2017y-05m-31d-08h-58m-36s UTC integration manifest
Comment 9 Humberto Israel Perez Rodriguez 2017-06-29 16:21:05 UTC
same issuw with the following test on GLK


testlist
igt@pm_rpm@sysfs-read
igt@pm_rpm@debugfs-read
igt@pm_rps@min-max-config-loaded


======================================
        Graphic drivers
======================================
Component: drm
    tag: libdrm-2.4.80-29-g7e6bf88
    commit: 7e6bf88cac315a9fa41818cf72a7b5d18a2cb1fc
Component: cairo
    tag: 1.15.4-28-g57b4050
    commit: 57b40507dda3f58dfc8635548d606b86dc7bcf51
Component: intel-gpu-tools
    tag: intel-gpu-tools-1.18-284-g9918014
    commit: 9918014df55d0393f99a31e3c398a4b38c90bb80
Component: piglit
    tag: piglit-v1
    commit: 1b8356e6dfa07480c154fccb47f6ef9c908ef652


======================================
             Kernel
======================================
commit 85a692e2c6a7cf93082044d776e838cb9e9b2146
Author:     Chris Wilson <chris@chris-wilson.co.uk>
AuthorDate: Wed Jun 28 15:25:29 2017 +0100
Commit:     Chris Wilson <chris@chris-wilson.co.uk>
CommitDate: Wed Jun 28 15:25:29 2017 +0100
Comment 10 maria guadalupe 2017-07-12 16:35:28 UTC
issue is still present over BDW with the following configuration 

test
=====================================
igt@pm_rpm@sysfs-read
igt@pm_rpm@pc8-residency
igt@pm_rpm@modeset-pc8-residency-stress
igt@pm_rpm@debugfs-read
igt@pm_rpm@gem-execbuf-stress-pc8

 Software
======================================
kernel version              : 4.12.0-drm-tip-ww28-commit-f1619bb+
architecture                : x86_64
os version                  : Ubuntu 16.10
os codename                 : yakkety
kernel driver               : i915
bios revision               : 5.6
hardware acceleration       : disabled
swap partition              : enabled on (/dev/sda3)

======================================
        Graphic drivers
======================================
modesetting                 : enabled
modesetting compiled for    : 1.18.4 X.Org Video Driver
xorg-xserver                : 1.18.4
libdrm                      : 2.4.70
libva                       : 1.7.1-2
vaapi (intel-driver)        : 1.7.1
cairo                       : 1.14.6-1build1
intel-gpu-tools             : 1.16-1

======================================
             Hardware
======================================
platform                   : Broadwell
motherboard id             : NUC5i5MYBE
form factor                : Desktop
cpu family                 : Core i5
cpu information            : Intel(R) Core(TM) i5-5300U CPU @ 2.30GHz
gpu card                   : Intel Corporation HD Graphics 5500 (rev 09) (prog-if 00 [VGA controller])
memory ram                 : 11.62 GB
max memory ram             : 16 GB
signature                  : Type 0, Family 6, Model 61, Stepping 4
hard drive                 : 111GiB (120GB)
current cd clock frequency : 337500 kHz
maximum cd clock frequency : 540000 kHz
displays connected         : DP-1 DP-2
Comment 11 Ricardo Madrigal 2017-07-20 15:17:05 UTC
The following tests fail on BYT with latest configuration

====================================================
Test list
====================================================
igt@pm_rpm@debugfs-read
igt@pm_rpm@sysfs-read

====================================================
Graphic Stack
====================================================
Component: drm
     tag: libdrm-2.4.81-31-g23e234a
     commit: 23e234a3503f51b9d9c585123d33b936f522808d
Component: cairo
    tag: 1.15.6-2-g57b4050
    commit: 57b40507dda3f58dfc8635548d606b86dc7bcf51
Component: intel-gpu-tools
    tag: intel-gpu-tools-1.19-96-gfb1ddc4
    commit: fb1ddc47003ad6a683db79beeb81b6cbab1feb7c
Component: piglit
    tag: piglit-v1
    commit: 56e7e5583cd4a3ca15a8cda154d46d168959dd25

======================================
             Hardware
======================================
motherboard model          : .................................
motherboard id             : DN2820FYK
form factor                : Desktop
manufacturer               : .................................
cpu family                 : Celeron
cpu family id              : 6
cpu information            : Intel(R) Celeron(R) CPU  N2830  @ 2.16GHz
gpu card                   : Intel Corporation Atom Processor Z36xxx/Z37xxx Series Graphics & Display (rev 0e) (prog-if 00 [VGA controller])
memory ram                 : 7.66 GB
max memory ram             : 8 GB
cpu thread                 : 2
cpu core                   : 2
cpu model                  : 55
cpu stepping               : 8
socket                     : <OUT OF SPEC>
signature                  : Type 0, Family 6, Model 55, Stepping 8
hard drive                 : 111GiB (120GB)
current cd clock frequency : 266667 kHz
maximum cd clock frequency : 400000 kHz
displays connected         : HDMI-A-1
Comment 12 Hector Velazquez 2017-07-31 19:55:03 UTC
The following tests FAIL on BSW with this configuration

Tests List:

igt@pm_rpm@debugfs-read



This is my configuration:

**************************************************************
* * * * * * * * HARDWARE SPECIFICATIONS * * * * * * * * * * * 
**************************************************************

==============================================================
Essentials
==============================================================
Processor Number			N3700
Status					Launched
Launch Date				Q1'15
Lithography				14 nm


==============================================================
Performance
==============================================================
# of Cores				4
# of Threads				4
Processor Base Frequency		1.60 GHz
Burst Frequency				2.40 GHz
Cache					2 MB L2
TDP					6 W
Scenario Design Power (SDP)		4 W

==============================================================
Memory Specifications
==============================================================
Max Memory Size 			8 GB
Memory Types				DDR3L-1600
Max # of Memory Channels		2
ECC Memory Supported  			No

==============================================================
Graphics Specifications
==============================================================
Processor Graphics 			Intel® HD Graphics
Graphics Base Frequency			400.00 MHz
Graphics Burst Frequency		700.00 MHz
Graphics Video Max Memory		8 GB
Graphics Output				eDP/DP/HDMI
Execution Units				16
DirectX* Support			Yes
OpenGL* Support				Yes
Intel® Quick Sync Video 		Yes
Intel® InTru™ 3D Technology		No
Intel® Clear Video HD Technology	Yes
Intel® Clear Video Technology		Yes
Intel® Wireless Display 		Yes
# of Displays Supported 		3


====================================================
Graphic Stack
====================================================

Component: drm
    tag: libdrm-2.4.81-33-g3876bc2
    commit: 3876bc246a07070a6043159cd7623d4def9bbd4c

Component: cairo
    tag: 1.15.6-2-g57b4050
    commit: 57b40507dda3f58dfc8635548d606b86dc7bcf51

Component: intel-gpu-tools
    tag: intel-gpu-tools-1.19-112-g493151b
    commit: 493151b0768aa4ca535cef49cb7efa174a9c3a77

Component: piglit
    tag: piglit-v1
    commit: 973892687cf5c2f8e2dbe1d22998b82736643787
Comment 13 Martin Peres 2017-08-16 09:56:34 UTC
Renaming the bug and bumping up the priority because it impacts CI.
Comment 14 Jari Tahvanainen 2017-08-22 11:58:36 UTC
I did some bisecting related to this and found out that change from pass to fail was actually caused by igt commit ced87bd9.
commit ced87bd913bfbfb8ecbe6352d87d133e5e4c81ff
Author:     Chris Wilson <chris@chris-wilson.co.uk>
AuthorDate: Sat Apr 8 13:15:18 2017 +0100
Commit:     Chris Wilson <chris@chris-wilson.co.uk>
CommitDate: Sat Apr 8 13:47:53 2017 +0100
    igt/pm_rpm: Use directory fd to track and read entire directories
    Rather than compute the temporary full path name, remember it via the dir
    fd we already have.
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Here is the actual outputs for this particular test on the latest kernel 
    drm-tip: 2017y-08m-21d-08h-13m-34s UTC integration manifest

dev-skl-i5-6600k:/opt/source/intel-gpu-tools/tests$ sudo ./pm_rpm --r debugfs-read
IGT-Version: 1.18-gced87bd9 (x86_64) (Linux: 4.13.0-rc5-ezbench_dbfb2f62576e+ x86_64)
Runtime PM support: 1
PC8 residency support: 0
(pm_rpm:1263) CRITICAL: Test assertion failure function read_full_file, file pm_rpm.c:838:
(pm_rpm:1263) CRITICAL: Failed assertion: wait_for_suspended()
(pm_rpm:1263) CRITICAL: Last errno: 19, No such device
(pm_rpm:1263) CRITICAL: File: i915_forcewake_user
Stack trace:
  #0 [__igt_fail_assert+0x101]
  #1 [read_files_from_dir+0x275]
  #2 [main+0x1a86]
  #3 [__libc_start_main+0xf1]
  #4 [_start+0x2a]
  #5 [<unknown>+0x2a]
Subtest debugfs-read failed.
**** DEBUG ****
(pm_rpm:1263) CRITICAL: Test assertion failure function read_full_file, file pm_rpm.c:838:
(pm_rpm:1263) CRITICAL: Failed assertion: wait_for_suspended()
(pm_rpm:1263) CRITICAL: Last errno: 19, No such device
(pm_rpm:1263) CRITICAL: File: i915_forcewake_user
****  END  ****
Subtest debugfs-read: FAIL (12,578s)

dev-skl-i5-6600k:/opt/source/intel-gpu-tools/tests$ sudo ./pm_rpm --r debugfs-read
IGT-Version: 1.18-gc3268d9a (x86_64) (Linux: 4.13.0-rc5-ezbench_dbfb2f62576e+ x86_64)
Runtime PM support: 1
PC8 residency support: 0
Subtest debugfs-read: SUCCESS (2,729s)
Comment 15 Chris Wilson 2017-08-24 10:11:47 UTC
https://patchwork.freedesktop.org/series/29141/ in particular note the improvements for both sysfs-read and debufs-read in https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_90/shards.html
Comment 16 Jari Tahvanainen 2017-08-30 14:48:39 UTC
Tested-by/SKL: I see the same improvement (FAIL -> SUCCESS) with igt+series (https://patchwork.freedesktop.org/series/29141/) used on latest drm-tip kernel drm-tip: "2017y-08m-30d-08h-12m-34s UTC integration manifest".
Looping ./pm_rpm --r debugfs-read ten times resulted ten times
Subtest debugfs-read: SUCCESS (2,...s).
When trying to run this test 1000 times in loop stops after few hundred executions, on which I do not have root cause visible yet.
Comment 17 Jari Tahvanainen 2017-08-31 07:31:35 UTC
Moving to IGT component since fixing is done there...
Comment 18 Jari Tahvanainen 2017-09-01 10:33:52 UTC
And after making clean setup on my dev-skl, 1000 repetitions of test case were all having SUCCESS as verdict.
Comment 19 Hector Velazquez 2017-09-05 20:28:09 UTC
The following tests FAIL on HSW 

Tests List:

igt@pm_rpm@debugfs-read
igt@pm_rpm@sysfs-read

This is my configuration:

======================================
        Graphic stack
======================================

Component: drm
    tag: libdrm-2.4.81-52-g05a830d
    commit: 05a830d382382905d87b55af90aa109fb76e4c16

Component: cairo
    tag: 1.15.6-30-gc29db4f
    commit: c29db4f0de52727406a8b62f4da9a382084b5a79

Component: intel-gpu-tools
    tag: intel-gpu-tools-1.19-234-g490b386
    commit: 490b386ae36d393cdea514882a2437c6e964c13f

Component: piglit
    tag: piglit-v1
    commit: dab15137044c34023b1a843e72e781b03b17548b

======================================
	     Software
======================================
kernel version              : 4.13.0-drm-tip-ww36-commit-9dd459e+
hostname                    : gfx-desktop
architecture                : x86_64
os version                  : Ubuntu 16.10
os codename                 : yakkety
kernel driver               : i915
bios revision               : 4.6
bios release date           : 03/02/2017
hardware acceleration       : disabled
swap partition              : enabled on (/dev/sda3)

======================================
	Graphic drivers
======================================
libdrm                      : 2.4.83
cairo                       : 1.15.9
intel-gpu-tools (tag)       : intel-gpu-tools-1.19-234-g490b386
intel-gpu-tools (commit)    : 490b386

======================================
	     Hardware
======================================
platform                   : Haswell-Nuc
motherboard id             : D54250WYK
form factor                : Desktop
cpu family                 : Core i5
cpu family id              : 6
cpu information            : Intel(R) Core(TM) i5-4250U CPU @ 1.30GHz
gpu card                   : Intel Corporation Haswell-ULT Integrated Graphics Controller (rev 09) (prog-if 00 [VGA controller])
memory ram                 : 1.83 GB
max memory ram             : 16 GB
cpu thread                 : 4
cpu core                   : 2
cpu model                  : 69
cpu stepping               : 1
socket                     : Socket LGA1150
signature                  : Type 0, Family 6, Model 69, Stepping 1
hard drive                 : 223GiB (240GB)
current cd clock frequency : 450000 kHz
maximum cd clock frequency : 450000 kHz
displays connected         : DP-1
Comment 20 Hector Velazquez 2017-09-06 17:21:02 UTC
The following tests FAIL on SKL 

Tests List:

igt@pm_rpm@debugfs-read
igt@pm_rpm@sysfs-read



This is my configuration:

======================================
        Graphic stack
======================================

Component: drm
    tag: libdrm-2.4.81-52-g05a830d
    commit: 05a830d382382905d87b55af90aa109fb76e4c16

Component: cairo
    tag: 1.15.6-30-gc29db4f
    commit: c29db4f0de52727406a8b62f4da9a382084b5a79

Component: intel-gpu-tools
    tag: intel-gpu-tools-1.19-234-g490b386
    commit: 490b386ae36d393cdea514882a2437c6e964c13f

Component: piglit
    tag: piglit-v1
    commit: dab15137044c34023b1a843e72e781b03b17548b

======================================
	     Software
======================================
kernel version              : 4.13.0-drm-tip-ww36-commit-9dd459e+
hostname                    : gfx-desktop
architecture                : x86_64
os version                  : Ubuntu 16.10
os codename                 : yakkety
kernel driver               : i915
bios revision               : 5.6
bios release date           : 09/29/2016
hardware acceleration       : only available on X
swap partition              : enabled on (/dev/sda3)

======================================
	Graphic drivers
======================================
libdrm                      : 2.4.83
cairo                       : 1.15.9
intel-gpu-tools (tag)       : intel-gpu-tools-1.19-234-g490b386
intel-gpu-tools (commit)    : 490b386

======================================
	     Firmware
======================================
dmc fw loaded             : yes
dmc version               : 1.26
guc fw loaded             : SUCCESS
guc version wanted        : 6.1
guc version found         : 6.1
huc fw loaded             : yes


======================================
	     Hardware
======================================
platform                   : Skylake Canyon
motherboard id             : NUC6i7KYB
form factor                : Desktop
cpu family                 : Core i7
cpu family id              : 6
cpu information            : Intel(R) Core(TM) i7-6770HQ CPU @ 2.60GHz
gpu card                   : Intel Corporation Iris Pro Graphics 580 (rev 09) (prog-if 00 [VGA controller])
memory ram                 : 31.31 GB
max memory ram             : 32 GB
cpu thread                 : 8
cpu core                   : 4
cpu model                  : 94
cpu stepping               : 3
socket                     : Other
signature                  : Type 0, Family 6, Model 94, Stepping 3
hard drive                 : 223GiB (240GB)
current cd clock frequency : 337500 kHz
maximum cd clock frequency : 675000 kHz
displays connected         : DP-1 DP-3


======================================
	     kernel parameters
======================================
quiet splash drm.debug=0x1e i915.enable_guc_submission=2 i915.enable_guc_loading=2 i915.alpha_support=1
Comment 21 Luis Botello 2017-09-06 17:26:43 UTC
Issue is also seen on CFL with the following config:

======================================
             Hardware
======================================
motherboard model          : CoffeeLakeClientPlatform
motherboard id             : CoffeeLakeSUDIMMRVP
form factor                : Desktop
manufacturer               : IntelCorporation
cpu family id              : 6
cpu information            : Genuine Intel(R) CPU 0000 @ 3.60GHz
gpu card                   : Intel Corporation Device 3e92 (prog-if 00 [VGA controller])
memory ram                 : 15.58 GB
max memory ram             : 32 GB
display resolution         : 1920x1080
cpu thread                 : 12
cpu core                   : 6
cpu model                  : 158
cpu stepping               : 10
socket                     : Other
hard drive                 : 111GiB (120GB)
current cd clock frequency : 337500 kHz
maximum cd clock frequency : 675000 kHz
displays connected         : eDP-1 DP HDMI
Comment 22 Chris Wilson 2017-09-06 18:07:24 UTC
commit e56ab79711b3fb248bf165d1601acd25a2b7529d
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Aug 22 13:47:33 2017 +0100

    igt/pm_rpm: Use libc 'ftw' rather than opencoding our own filetree walk
    
    By using ftw, we avoid the issue of having to handle directory recursion
    ourselves and can focus on the test of checking the reading a
    sysfs/debugfs does not break runtime suspend. In the process, disregard
    errors when opening the individual files as they may fail for other
    reasons.
    
    v2: Bracket the file open/close with the wait_for_suspended() tests.
    Whilst the fd is open, it may be keeping the device awake, e.g.
    i915_forcewake_user.
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Tested-by: Jari Tahvanainen <jari.tahvanainen@intel.com>
Comment 23 Martin Peres 2017-09-07 07:48:21 UTC
Verified fixed! Thanks Chris!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.