Bug 100934 - i810_video.c:1149:5: error: too many arguments to function 'screen->BlockHandler'
Summary: i810_video.c:1149:5: error: too many arguments to function 'screen->BlockHand...
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Chris Wilson
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-04 18:30 UTC by YuGiOhJCJ
Modified: 2017-05-05 06:47 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description YuGiOhJCJ 2017-05-04 18:30:22 UTC
Hello,

I am trying to build "xf86-video-intel-2.99.917" on Slackware64 14.2 and here is what I get:
---
$ make
[...]
make[5]: Entering directory `/tmp/build/dri3proto/xf86-video-intel-2.99.917/src/legacy/i810'
  CC       i810_video.lo
i810_video.c:208:48: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    {XvSettable | XvGettable, 0, (1 << 24) - 1, "XV_COLORKEY"},
                                                ^
i810_video.c:209:41: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    {XvSettable | XvGettable, -128, 127, "XV_BRIGHTNESS"},
                                         ^
i810_video.c:210:38: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    {XvSettable | XvGettable, 0, 255, "XV_CONTRAST"}
                                      ^
i810_video.c: In function 'I810SetupImageVideo':
i810_video.c:422:26: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
     screen->BlockHandler = I810BlockHandler;
                          ^
i810_video.c: In function 'I810BlockHandler':
i810_video.c:1149:5: error: too many arguments to function 'screen->BlockHandler'
     (*screen->BlockHandler) (BLOCKHANDLER_ARGS);
     ^
i810_video.c:1151:26: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
     screen->BlockHandler = I810BlockHandler;
                          ^
i810_video.c: In function 'I810DisplaySurface':
i810_video.c:1376:36: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
       pScrn->pScreen->BlockHandler = I810BlockHandler;
                                    ^
make[5]: *** [i810_video.lo] Error 1
make[5]: Leaving directory `/tmp/build/dri3proto/xf86-video-intel-2.99.917/src/legacy/i810'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory `/tmp/build/dri3proto/xf86-video-intel-2.99.917/src/legacy/i810'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/tmp/build/dri3proto/xf86-video-intel-2.99.917/src/legacy'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/build/dri3proto/xf86-video-intel-2.99.917/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/build/dri3proto/xf86-video-intel-2.99.917'
make: *** [all] Error 2
---

Here is my Xorg/Mesa configuration:
bigreqsproto-1.1.2
compositeproto-0.4.2
damageproto-1.2.1
dri2proto-2.8
dri3proto-1.0
fixesproto-5.0
fontsproto-2.1.3
freeglut-3.0.0
glew-1.13.0
glproto-1.4.17
glu-9.0.0
inputproto-2.3.2
kbproto-1.0.7
libdrm-2.4.80
libepoxy-1.4.1
libevdev-1.5.6
libfontenc-1.1.3
libICE-1.0.9
libinput-1.7.1
libpciaccess-0.13.5
libpthread-stubs-0.1
libSM-1.2.2
libvdpau-1.1.1
libwacom-0.24
libX11-1.6.5
libXau-1.0.8
libxcb-1.12
libXcomposite-0.4.4
libXcursor-1.1.14
libXdamage-1.1.4
libXext-1.3.3
libXfixes-5.0.3
libXfont2-2.0.1
libXi-1.7.9
libxkbfile-1.0.9
libXmu-1.1.2
libXrender-0.9.10
libxshmfence-1.2
libXt-1.1.5
mesa-17.0.4
mesa-demos-8.3.0
mtdev-1.1.5
pixman-0.34.0
presentproto-1.1
randrproto-1.5.0
recordproto-1.14.2
renderproto-0.11.1
resourceproto-1.2.0
scrnsaverproto-1.2.2
videoproto-2.3.3
xauth-1.0.10
xbitmaps-1.1.0
xcb-proto-1.12
xcmiscproto-1.2.2
xextproto-7.3.0
xf86driproto-2.1.1
xf86-input-evdev-2.9.2
xf86-input-libinput-0.25.0
xf86-video-intel-2.99.917
xineramaproto-1.2.1
xinit-1.3.4
xkbcomp-1.4.0
xkeyboard-config-2.5.1
xmodmap-1.0.9
xorg-server-1.19.3
xproto-7.0.31
xset-1.2.3
xsetroot-1.1.1
xtrans-1.3.5

Any patch for that please?

Thank you.
Best regards.
Comment 1 Chris Wilson 2017-05-04 20:26:58 UTC
commit d39197bb10b7d88cb4c456e7a5e8d34c1dc6eeaf
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Jul 21 12:33:29 2016 +0100

    legacy/i810: Fix compilation with Video ABI 23 changes

?
Comment 2 YuGiOhJCJ 2017-05-05 06:47:28 UTC
Thanks indeed this commit compiles fine:
$ git clone git://anongit.freedesktop.org/xorg/driver/xf86-video-intel
$ cd xf86-video-intel
$ git checkout d39197bb10b7d88cb4c456e7a5e8d34c1dc6eeaf
$ git archive HEAD -o /tmp/xf86-video-intel-d39197bb10b7d88cb4c456e7a5e8d34c1dc6eeaf.tar
$ cd /tmp
$ mkdir xf86-video-intel-d39197bb10b7d88cb4c456e7a5e8d34c1dc6eeaf
$ cd xf86-video-intel-d39197bb10b7d88cb4c456e7a5e8d34c1dc6eeaf
$ tar xvf ../xf86-video-intel-d39197bb10b7d88cb4c456e7a5e8d34c1dc6eeaf.tar
$ cd ..
$ tar Jcvf xf86-video-intel-d39197bb10b7d88cb4c456e7a5e8d34c1dc6eeaf.tar.xz xf86-video-intel-d39197bb10b7d88cb4c456e7a5e8d34c1dc6eeaf
$ rm xf86-video-intel-d39197bb10b7d88cb4c456e7a5e8d34c1dc6eeaf.tar
$ cd xf86-video-intel-d39197bb10b7d88cb4c456e7a5e8d34c1dc6eeaf
$ autoreconf -i
$ ./configure
$ make

Problem solved.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.