Bug 100945 - Build failure in GNOME Continuous
Summary: Build failure in GNOME Continuous
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Vulkan/intel (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Intel 3D Bugs Mailing List
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-05 09:27 UTC by Emmanuele Bassi (:ebassi)
Modified: 2017-05-05 19:50 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emmanuele Bassi (:ebassi) 2017-05-05 09:27:55 UTC
Mesa fails to build on the GNOME Continuous integration pipeline:

http://build.gnome.org/continuous/buildmaster/builds/2017/05/05/12/build/log-mesa.txt

../../../src/intel/vulkan/anv_allocator.c: In function 'anv_state_stream_alloc':
../../../src/intel/vulkan/anv_allocator.c:930:28: error: 'struct anv_state_stream_block' has no member named '_vg_ptr'
       VG_NOACCESS_WRITE(&sb->_vg_ptr, NULL);
                            ^
../../../src/intel/vulkan/anv_allocator.c:53:44: note: in definition of macro 'VG_NOACCESS_WRITE'
 #define VG_NOACCESS_WRITE(__ptr, __val) (*(__ptr) = (__val))
                                            ^
../../../src/intel/vulkan/anv_allocator.c: At top level:
../../../src/intel/vulkan/anv_allocator.c:1214:1: warning: 'anv_bo_cache_lookup' defined but not used [-Wunused-function]
 anv_bo_cache_lookup(struct anv_bo_cache *cache, uint32_t gem_handle)
 ^
mv -f vulkan/.deps/vulkan_libvulkan_common_la-anv_nir_lower_push_constants.Tpo vulkan/.deps/vulkan_libvulkan_common_la-anv_nir_lower_push_constants.Plo
../../../src/intel/vulkan/anv_queue.c: In function 'anv_WaitForFences':
../../../src/intel/vulkan/anv_queue.c:384:8: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
    int ret;
        ^
Makefile:3284: recipe for target 'vulkan/vulkan_libvulkan_common_la-anv_allocator.lo' failed
make[4]: *** [vulkan/vulkan_libvulkan_common_la-anv_allocator.lo] Error 1
Comment 1 Jason Ekstrand 2017-05-05 19:50:47 UTC
Fixed by the following commit in master:

commit e05e3e07ab47a8108b8a8d257d7e8acc1f7cf584
Author: Jason Ekstrand <jason.ekstrand@intel.com>
Date:   Fri May 5 12:11:42 2017 -0700

    anv/allocator: Only write to _vg_ptr if we have valgrind
    
    This fixes the build when not building against valgrind headers.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100945
    Reviewed-by: Chad Versace <chadversary@chromium.org>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.