Bug 100970 - evdev keys KEY_RFKILL and KEY_WWAN are not currently mapped
Summary: evdev keys KEY_RFKILL and KEY_WWAN are not currently mapped
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
Depends on:
Reported: 2017-05-08 14:03 UTC by Benjamin Berg
Modified: 2018-04-19 06:05 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Map evdev keycodes KEY_RFKILL and KEY_WWAN to XF86RFKill and XF86WWAN (1.73 KB, patch)
2017-05-08 14:03 UTC, Benjamin Berg
Details | Splinter Review

Description Benjamin Berg 2017-05-08 14:03:03 UTC
Attaching a patch to handle these. Note that the patch removes an XF86Hibernate mapping which looks like it could not have been used (no mapping to I255 in eycodes/evdev).

In particular KEY_RFKILL is important is it is used on a lot of laptop models. KEY_WWAN (or the alias KEY_WIMAX) is currently not used on any x86 system in the kernel.
Comment 1 Benjamin Berg 2017-05-08 14:03:56 UTC
Created attachment 131261 [details] [review]
Map evdev keycodes KEY_RFKILL and KEY_WWAN to XF86RFKill and XF86WWAN

In particular KEY_RFKILL is required for properly handling airplane mode
in userspace.
Comment 2 Sergey V. Udaltsov 2017-05-08 14:14:30 UTC
I am worried. Is the key code 255 allowed??
Comment 3 Sergey V. Udaltsov 2017-05-08 14:22:47 UTC
Sorry, stupid question in the previous comment. Of course Hibernate key was using 255.

What is going to configurations actually using 255 for hibernation?
Comment 4 Benjamin Berg 2017-05-08 15:40:20 UTC
I believe it is permissible but I have not actually verified this as of now. I have not verified as of now, but am happy to do so before this is merged.
Comment 5 Benjamin Berg 2017-05-08 15:44:21 UTC
I don't think any key was mapped to 255 in the past. So effectively this should be removing a dead key (XF86Hibernate) and adding the new XF86RFKill.
Comment 6 Hans de Goede 2017-05-12 14:19:54 UTC
I've just submitted a slightly different patch (which adds mappings for a few more keys) upstream here:

I will push this upstream as soon as I get an ack.
Comment 7 Sergey V. Udaltsov 2018-02-01 13:42:22 UTC
Committed! Enjoy! And thank you:)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.