Bug 101052 - daemon: don't treat explicitly requested users as "cached"
Summary: daemon: don't treat explicitly requested users as "cached"
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-15 21:12 UTC by Ray Strode [halfline]
Modified: 2017-05-15 21:13 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
daemon: don't treat explicitly requested users as "cached" (24.76 KB, patch)
2017-05-15 21:13 UTC, Ray Strode [halfline] 		Details | Splinter Review
View All

Description Ray Strode [halfline] 2017-05-15 21:12:50 UTC 
The ListCachedUsers method currently returns users that have
been explicitly requested by a client.  It's weird that merely
querying a user can make it show up in login screen user lists.
Furthermore, UncacheUser is broken since commit
177509e9460b149ecbf85e75c930be2ea00b7d05 because the user has
been explicitly requested in order to uncache it.  So trying
to uncache a user inadvertently caches the user.

This commit fixes that.
Comment 1 Ray Strode [halfline] 2017-05-15 21:13:01 UTC 
Created attachment 131370 [details] [review]
daemon: don't treat explicitly requested users as "cached"
Comment 2 Ray Strode [halfline] 2017-05-15 21:13:16 UTC 
Attachment 131370 [details] pushed as edac457 - daemon: don't treat explicitly requested users as "cached"

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.