Created attachment 131423 [details] [review]
application/x-msx-rom: Add .rom glob and magic value

Comment on attachment 131423 [details] [review]
application/x-msx-rom: Add .rom glob and magic value

Review of attachment 131423 [details] [review]:
-----------------------------------------------------------------

::: freedesktop.org.xml.in
@@ +2969,5 @@
>      <generic-icon name="application-x-executable"/>
>      <glob pattern="*.msx"/>
> +    <glob pattern="*.rom"/>
> +    <magic>
> +      <match type="string" value="AB" offset="0"/>

Is that really all we can do? That's a very short magic :/

(In reply to Bastien Nocera from comment #2)
> Comment on attachment 131423 [details] [review] [review]
> application/x-msx-rom: Add .rom glob and magic value
> 
> Review of attachment 131423 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: freedesktop.org.xml.in
> @@ +2969,5 @@
> >      <generic-icon name="application-x-executable"/>
> >      <glob pattern="*.msx"/>
> > +    <glob pattern="*.rom"/>
> > +    <magic>
> > +      <match type="string" value="AB" offset="0"/>
> 
> Is that really all we can do? That's a very short magic :/

That's at least the least common denominator of the magic and AFAICT the only thing we can really use, I'll keep exploring but don't get much hope. :/

Created attachment 131459 [details] [review]
application/x-msx-rom: Add .rom glob and magic value

Comment on attachment 131459 [details] [review]
application/x-msx-rom: Add .rom glob and magic value

Review of attachment 131459 [details] [review]:
-----------------------------------------------------------------

I'll see whether I can commit the tests though.

::: freedesktop.org.xml.in
@@ +2975,5 @@
>    <mime-type type="application/x-msx-rom">
>      <_comment>MSX ROM</_comment>
>      <generic-icon name="application-x-executable"/>
> +    <magic>
> +      <match type="string" value="AB" offset="0"/>

This is far too short.

@@ +2981,2 @@
>      <glob pattern="*.msx"/>
> +    <glob pattern="*.rom"/>

And this is far too generic (which would be fine if we also had magic, but it's too short).

commit 8a3f5b02d08745ea7259eff13e44c326e6323d04
Author: Adrien Plazas <kekun.plazas@laposte.net>
Date:   Sun May 21 09:01:09 2017 +0200

    Add test files for application/x-msx-rom
    
    https://bugs.freedesktop.org/show_bug.cgi?id=101133

Please file a new bug when you find better magic, as it is, it's too short and generic.