Bug 101137 - Add a Virtual Boy type
Summary: Add a Virtual Boy type
Status: RESOLVED FIXED
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: freedesktop.org.xml (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Shared Mime Info group
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-21 11:20 UTC by Adrien Plazas
Modified: 2017-09-05 12:33 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Add application/x-virtual-boy-rom (2.19 KB, patch)
2017-05-21 11:20 UTC, Adrien Plazas
Details | Splinter Review

Description Adrien Plazas 2017-05-21 11:20:32 UTC
Created attachment 131427 [details] [review]
Add application/x-virtual-boy-rom

.
Comment 1 Adrien Plazas 2017-05-21 11:23:42 UTC
There may be a collision between Virtual Boy ROM files and Visual Basic source files.
Comment 2 Bastien Nocera 2017-05-21 14:02:20 UTC
(In reply to Adrien Plazas from comment #1)
> There may be a collision between Virtual Boy ROM files and Visual Basic
> source files.

Which could be a reason for it to need magic.
Comment 3 Adrien Plazas 2017-05-21 14:21:01 UTC
(In reply to Bastien Nocera from comment #2)
> Which could be a reason for it to need magic.

Unfortunately I didn't find interesting information about that, IIUC the header is at the end of the file, it doesn't contain useful information in our case, and I couldn't verify this information on the files I found… hence the absence of a magic in my patch.

I'll keep exploring.
Comment 4 Adrien Plazas 2017-05-21 17:06:42 UTC
(In reply to Adrien Plazas from comment #3)
> I'll keep exploring.

I confirm that there is no header but a footer, and I didn't see any magic value in it.

Could there be one in Visual Basic source code files?
Comment 5 Bastien Nocera 2017-09-05 12:33:24 UTC
commit 802530ada012a36ed63c4c15e7547b88582e7b79
Author: Adrien Plazas <kekun.plazas@laposte.net>
Date:   Sun May 21 13:18:31 2017 +0200

    Add application/x-virtual-boy-rom
    
    There may be a collision between Virtual Boy ROM files and Visual
    Basic source files, but those don't have any test files, so we
    cannot know.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=101137


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.