Bug 101258 - LONG_FAMILY_NAMES check still broken
Summary: LONG_FAMILY_NAMES check still broken
Status: RESOLVED FIXED
Alias: None
Product: fontconfig
Classification: Unclassified
Component: library (show other bugs)
Version: 2.12
Hardware: All All
: medium normal
Assignee: fontconfig-bugs
QA Contact: Behdad Esfahbod
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-31 19:44 UTC by Jan Alexander Steffens (heftig)
Modified: 2017-06-01 02:40 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[PATCH] Fix testing PCF_CONFIG_OPTION_LONG_FAMILY_NAMES (CFLAGS need to be right) (2.65 KB, patch)
2017-05-31 19:44 UTC, Jan Alexander Steffens (heftig)
Details | Splinter Review

Description Jan Alexander Steffens (heftig) 2017-05-31 19:44:24 UTC
Created attachment 131620 [details] [review]
[PATCH] Fix testing PCF_CONFIG_OPTION_LONG_FAMILY_NAMES (CFLAGS need to be right)

The PCF_CONFIG_OPTION_LONG_FAMILY_NAMES check is still broken as of 2.12.3, as the check does not include the FREETYPE_CFLAGS and so is missing the includedir. 

The check fails because ft2build.h cannot be found.

The attached patch extends the LIBS/CFLAGS modification used to test the FreeType funcs and members to cover the test for the config flag.
Comment 1 Akira TAGOH 2017-06-01 02:40:41 UTC
Thanks. merged.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.