Bug 101350 - Erroneous test on language id in FcLangSetPromote()
Summary: Erroneous test on language id in FcLangSetPromote()
Status: RESOLVED FIXED
Alias: None
Product: fontconfig
Classification: Unclassified
Component: library (show other bugs)
Version: 2.12
Hardware: All All
: medium normal
Assignee: fontconfig-bugs
QA Contact: Behdad Esfahbod
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-08 14:02 UTC by Florent Rougon
Modified: 2017-06-09 06:52 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Commit (as output by 'git format-patch') (847 bytes, patch)
2017-06-08 14:02 UTC, Florent Rougon
Details | Splinter Review

Description Florent Rougon 2017-06-08 14:02:59 UTC
Created attachment 131803 [details] [review]
Commit (as output by 'git format-patch')

As written at: https://lists.freedesktop.org/archives/fontconfig/2017-June/005942.html

FcLangSetIndex() indicates "not found" with a non-negative return value.
Return value 0 doesn't imply "not found", it rather means "language
found at index 0 in fcLangCharSets". See attached patch for the
precise location.
Comment 1 Akira TAGOH 2017-06-09 06:52:55 UTC
Thanks. merged in git.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.