Bug 101700 - Normal users can't fetch bus driver properties on system bus
Summary: Normal users can't fetch bus driver properties on system bus
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: D-Bus Maintainers
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks: 101354
  Show dependency treegraph
 
Reported: 2017-07-05 17:01 UTC by Simon McVittie
Modified: 2017-07-06 18:05 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
system.conf: Allow unprivileged users to get dbus-daemon properties (960 bytes, patch)
2017-07-05 17:01 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2017-07-05 17:01:49 UTC
Created attachment 132461 [details] [review]
system.conf: Allow unprivileged users to get dbus-daemon  properties

---

Bug #101256 added Features and Interfaces properties to the dbus-daemon, but did not allow system bus users to read them. This was not intentional.

If we ever add properties that are security-sensitive, then we'll need to control access to them somehow, but (a) the XML policy language can't express the equivalent of arg0 match rules, and (b) I think flags in bus/driver.c (INTERFACE_FLAG_PRIVILEGED?) would be a better way to do that anyway.
Comment 1 Philip Withnall 2017-07-05 17:05:57 UTC
Comment on attachment 132461 [details] [review]
system.conf: Allow unprivileged users to get dbus-daemon  properties

Review of attachment 132461 [details] [review]:
-----------------------------------------------------------------

++
Comment 2 Simon McVittie 2017-07-06 18:05:07 UTC
Thanks, pushed for 1.11.16.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.