Bug 101840 - Add eolie to allowed applications
Summary: Add eolie to allowed applications
Status: RESOLVED INVALID
Alias: None
Product: GeoClue
Classification: Unclassified
Component: service (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Geoclue Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-19 12:27 UTC by Cédric Bellegarde
Modified: 2017-08-23 12:50 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Cédric Bellegarde 2017-07-19 12:27:23 UTC
Hello,

I'm working on a GTK/GNOME web browser: https://github.com/gnumdk/eolie

Please add it to allowed applications:

[eolie]
allowed=true
system=false
users=

A better solution may be to add a /etc/geoclue2.d allowing packagers to add files per application.
Comment 1 Zeeshan Ali 2017-07-19 12:57:11 UTC
(In reply to Cédric Bellegarde from comment #0)
> Hello,
> 
> I'm working on a GTK/GNOME web browser: https://github.com/gnumdk/eolie
> 
> Please add it to allowed applications:
> 
> [eolie]
> allowed=true
> system=false
> users=

Sorry but I can't add all the browsers here and I don't think it's worth it. Once your browser has sufficient user base and is well-known enough, I'm more than willing to add it to the whitelist then. 

Until then, it's fine for users to explicitly allow eolie to have access to location data. It's not that big a deal for user to have to click "allow" twice on the first page accessing location anyway.

> A better solution may be to add a /etc/geoclue2.d allowing packagers to add
> files per application.

That would mean each packager has to do this for each app so don't see the point.
Comment 2 Cédric Bellegarde 2017-07-19 16:16:50 UTC
>That would mean each packager has to do this for each app so don't see the point.

That would mean each developer add a file for each app, just that.

>it's fine for users to explicitly allow eolie to have access

WebKitGTK seems to assume access is ok and nothing is asked for user, geolocation is just refused.
Comment 3 Zeeshan Ali 2017-07-19 16:31:29 UTC
(In reply to Cédric Bellegarde from comment #2)
> >That would mean each packager has to do this for each app so don't see the point.
> 
> That would mean each developer add a file for each app, just that.

Not at all, most apps are not supposed to use the white list so that user can explicitly control which apps get access and which don't. This is expected to be a very short list.

> >it's fine for users to explicitly allow eolie to have access
> 
> WebKitGTK seems to assume access is ok and nothing is asked for user,
> geolocation is just refused.

Then that's a bug. Please check if you can reproduced it against other geoclue-using apps (gnome-clocks and gnome-maps etc) and if you can, it's likely a bug in either gnome-shell or geoclue. If it's a bug in geoclue, please file in a separate bug with details. If you could get access to geoclue console logs, that would be nice.
Comment 4 Cédric Bellegarde 2017-08-22 14:18:24 UTC
>most apps are not supposed to use the white list

Epiphany does, why?

>Please check if you can reproduced it against other geoclue-using apps (gnome-
>clocks and gnome-maps etc) 

WebKit devs assume that application is listed in allowed applications, bug is not in Shell or Geoclue.
Comment 5 Zeeshan Ali 2017-08-22 14:39:01 UTC
(In reply to Cédric Bellegarde from comment #4)
> >most apps are not supposed to use the white list
> 
> Epiphany does, why?

Because browsers are special. It's not the browser itself that needs to authorize but the webpages/websites and all browsers already allow users to control which ones get to access user's location information.

> >Please check if you can reproduced it against other geoclue-using apps (gnome-
> >clocks and gnome-maps etc) 
> 
> WebKit devs assume that application is listed in allowed applications, bug
> is not in Shell or Geoclue.

No they don't AFAIK. If an app that is not on the whitelist, talks to geoclue, geoclue asks the agent (if one is available and in your case it's gnome-shell) and agent then asks the user if app should be allowed or not, unless user has already denied the access.
Comment 6 Zeeshan Ali 2017-08-22 14:40:57 UTC
(In reply to Zeeshan Ali from comment #5)
> (In reply to Cédric Bellegarde from comment #4)
> > >most apps are not supposed to use the white list
> > 
> > Epiphany does, why?
> 
> Because browsers are special. It's not the browser itself that needs to
> authorize but the webpages/websites and all browsers already allow users to
> control which ones get to access user's location information.

More importantly, Epiphany is a well-known-enough browser, that I know have at least a 100 users. No offense but I've never heard of eolie before.
Comment 7 Bastien Nocera 2017-08-22 15:35:16 UTC
(In reply to Zeeshan Ali from comment #6)
> (In reply to Zeeshan Ali from comment #5)
> > (In reply to Cédric Bellegarde from comment #4)
> > > >most apps are not supposed to use the white list
> > > 
> > > Epiphany does, why?
> > 
> > Because browsers are special. It's not the browser itself that needs to
> > authorize but the webpages/websites and all browsers already allow users to
> > control which ones get to access user's location information.
> 
> More importantly, Epiphany is a well-known-enough browser, that I know have
> at least a 100 users. No offense but I've never heard of eolie before.

It's a new application. I think adding it to the whitelist would be quicker than carrying on with this discussion.

Cédric, can you please provide a git-formatted patch for this?
Comment 8 Zeeshan Ali 2017-08-22 15:49:30 UTC
(In reply to Bastien Nocera from comment #7)
> (In reply to Zeeshan Ali from comment #6)
> > (In reply to Zeeshan Ali from comment #5)
> > > (In reply to Cédric Bellegarde from comment #4)
> > > > >most apps are not supposed to use the white list
> > > > 
> > > > Epiphany does, why?
> > > 
> > > Because browsers are special. It's not the browser itself that needs to
> > > authorize but the webpages/websites and all browsers already allow users to
> > > control which ones get to access user's location information.
> > 
> > More importantly, Epiphany is a well-known-enough browser, that I know have
> > at least a 100 users. No offense but I've never heard of eolie before.
> 
> It's a new application. I think adding it to the whitelist would be quicker
> than carrying on with this discussion.

I was hoping it ended already and I don't think it's a very smart move to add things just to finish off a discussion.
Comment 9 Cédric Bellegarde 2017-08-23 12:50:25 UTC
Found a solution thanks to WebKitGTK devs:
https://bugs.webkit.org/show_bug.cgi?id=175824


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.