Bug 101843 - Latest mesa git fails to compile in mesa/main/marshal.c
Summary: Latest mesa git fails to compile in mesa/main/marshal.c
Status: RESOLVED WORKSFORME
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: Other Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-19 17:09 UTC by Fabian Maurer
Modified: 2017-07-20 23:27 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Fabian Maurer 2017-07-19 17:09:49 UTC
I'm on latest git tree, commit 80a0c9745cad25ca35ae6ea5b29363836cc21a66

I configure mesa with

../mesa-git/autogen.sh --prefix=/usr \
		   --sysconfdir=/etc \
		   --with-dri-driverdir=/usr/lib/xorg/modules/dri \
		   --with-gallium-drivers=radeonsi,swrast\
		   --with-dri-drivers=radeon,swrast \
		   --with-platforms=x11,drm \
		   --enable-texture-float \
		   --enable-xa \
		   --enable-glx-tls \
		   --enable-libglvnd 

Build fails with


../../../mesa-git/src/mesa/main/marshal.c: In function ‘_mesa_marshal_NamedBufferData’:
../../../mesa-git/src/mesa/main/marshal.c:456:47: error: ‘DISPATCH_CMD_NamedBufferData’ undeclared (first use in this function); did you mean ‘DISPATCH_CMD_BufferData’?
          _mesa_glthread_allocate_command(ctx, DISPATCH_CMD_NamedBufferData,
                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                               DISPATCH_CMD_BufferData
../../../mesa-git/src/mesa/main/marshal.c:456:47: note: each undeclared identifier is reported only once for each function it appears in
../../../mesa-git/src/mesa/main/marshal.c: In function ‘_mesa_marshal_NamedBufferSubData’:
../../../mesa-git/src/mesa/main/marshal.c:513:47: error: ‘DISPATCH_CMD_NamedBufferSubData’ undeclared (first use in this function); did you mean ‘DISPATCH_CMD_CopyNamedBufferSubData’?
          _mesa_glthread_allocate_command(ctx, DISPATCH_CMD_NamedBufferSubData,
                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                               DISPATCH_CMD_CopyNamedBufferSubData
../../../mesa-git/src/mesa/main/marshal.c: In function ‘_mesa_marshal_ClearBufferiv’:
../../../mesa-git/src/mesa/main/marshal.c:681:39: error: ‘DISPATCH_CMD_ClearBufferiv’ undeclared (first use in this function); did you mean ‘DISPATCH_CMD_ClearBufferfv’?
    if (!clear_buffer_add_command(ctx, DISPATCH_CMD_ClearBufferiv, buffer,
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
                                       DISPATCH_CMD_ClearBufferfv
../../../mesa-git/src/mesa/main/marshal.c: In function ‘_mesa_marshal_ClearBufferuiv’:
../../../mesa-git/src/mesa/main/marshal.c:710:39: error: ‘DISPATCH_CMD_ClearBufferuiv’ undeclared (first use in this function); did you mean ‘DISPATCH_CMD_ClearBufferfi’?
    if (!clear_buffer_add_command(ctx, DISPATCH_CMD_ClearBufferuiv, buffer,
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                                       DISPATCH_CMD_ClearBufferfi


Maybe there is something wrong with my setup? It used to work just fine, but some update led to mesa not compiling anymore.
Comment 1 Timothy Arceri 2017-07-20 00:45:20 UTC
It's working for me, if you could use git bisect to identify the bad commit that would be helpful.
Comment 2 Fabian Maurer 2017-07-20 02:31:58 UTC
Bisected to 95fb1c187a0ea8d13f401145282363228b91b246.

But I think I know the problem, did you try building out of tree? Because I have the build folder on the same level as my mesa-git folder. And building inside the git-folder itself doesn't lead to compile errors.
Comment 3 Grigori Goronzy 2017-07-20 08:55:54 UTC
Are you sure this isn't an issue with the build infrastructure going out of sync with changes in the source code? Please try to delete the build directory and reconfigure and rebuild everything from scratch. This looks like the generated code for marshalling wasn't updated properly.

I'm only using out-of-tree builds and Mesa builds fine for me too.
Comment 4 Fabian Maurer 2017-07-20 17:45:54 UTC
Well, now that I set it up again, it suddenly works. Maybe a configuration problem, but I really can't see what I changed.
Thank you for testing, is there an option to resolve this as WORKSFORME?


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.