Bug 101915 - [BAT] Spurious SKIP in igt@gem_ringfill@basic-default(-forked)?
Summary: [BAT] Spurious SKIP in igt@gem_ringfill@basic-default(-forked)?
Status: CLOSED WORKSFORME
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: DRI git
Hardware: Other All
: high critical
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-25 14:00 UTC by Martin Peres
Modified: 2017-09-07 20:22 UTC (History)
1 user (show)

See Also:
i915 platform: BSW/CHT, BXT
i915 features: GEM/Other


Attachments
result.log (1.85 KB, text/plain)
2017-08-02 16:43 UTC, Ricardo Madrigal
no flags Details

Description Martin Peres 2017-07-25 14:00:44 UTC
On the machines fi-bsw-n3050 and fi-bxt-j4205, we sometimes have the test igt@gem_ringfill@basic-default(-forked)? skip with the following message:

Ring size: 0 batches
Test requirement not met in function __real_main327, file gem_ringfill.c:363:
Test requirement: ring_size
Subtest basic-default-forked: SKIP

Full logs:
 - https://intel-gfx-ci.01.org/CI/CI_DRM_2823/fi-bsw-n3050/igt@gem_ringfill@basic-default-forked.html
 - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5271/fi-bsw-n3050/igt@gem_ringfill@basic-default.html
 - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5259/fi-bxt-j4205/igt@gem_ringfill@basic-default-forked.html
Comment 1 Chris Wilson 2017-07-25 15:48:03 UTC
diff --git a/tests/gem_ringfill.c b/tests/gem_ringfill.c
index b52996a4..01cbd0a9 100644
--- a/tests/gem_ringfill.c
+++ b/tests/gem_ringfill.c
@@ -288,10 +288,15 @@ static unsigned int measure_ring_size(int fd)
        obj[1].handle = gem_create(fd, 4096);
        gem_write(fd, obj[1].handle, 0, &bbe, sizeof(bbe));
 
+       memset(&execbuf, 0, sizeof(execbuf));
+       execbuf.buffers_ptr = to_user_pointer(obj + 1);
+       execbuf.buffer_count = 1;
+       gem_execbuf(fd, &execbuf);
+       gem_sync(fd, obj[1].handle);
+
        plug(fd, &c);
        obj[0].handle = c.handle;
 
-       memset(&execbuf, 0, sizeof(execbuf));
        execbuf.buffers_ptr = to_user_pointer(obj);
        execbuf.buffer_count = 2;
 
@@ -302,7 +307,8 @@ static unsigned int measure_ring_size(int fd)
        itv.it_value.tv_usec = 1000;
        setitimer(ITIMER_REAL, &itv, NULL);
 
-       last = count = 0;
+       last = -1;
+       count = 0;
        do {
                if (__execbuf(fd, &execbuf) == 0) {
                        count++;
Comment 2 Martin Peres 2017-07-26 19:35:25 UTC
So, what should we do with this patch? Should it be made into a real patch, reviewed and merged, in the hope it will fix the issue?

Or should we make a patch of it and try to reproduce the issue by running multiple times this test on the machines?

Tell us more :)
Comment 3 Ricardo Madrigal 2017-08-02 16:42:40 UTC
I ran the test of ./gem_ringfill --r basic-default-forked on BXT/BSW platforms,  and test was pass

Adding my configuration and output after test

======================================
BRASWELL
======================================
             Software
======================================
kernel version              : 4.13.0-rc3-drm-tip-ww31-commit-fcb630a+
/bin/bash: BSW-2-BRASWELL: command not found
architecture                : x86_64
os version                  : Ubuntu 16.10
os codename                 : yakkety
kernel driver               : i915
bios revision               : 0.33
bios release date           : 08/12/2015
ksc                         : 0.16
hardware acceleration       : disabled
swap partition              : enabled on (/dev/sda3)
======================================
        Graphic drivers
======================================
modesetting                 : enabled
modesetting compiled for    : 1.18.4 X.Org Video Driver
xorg-xserver                : 1.18.4
libdrm                    : 2.4.70
libva                       : 1.7.1-2
vaapi (intel-driver)        : 1.7.1
cairo                       : 1.14.6-1build1
intel-gpu-tools             : 1.16-1
======================================
             Hardware
======================================
platform                   : Braswell
motherboard model          : 10G9000NUS
motherboard id             : BRASWELL
form factor                : Desktop
manufacturer               : LENOVO
cpu family                 : Pentium
cpu family id              : 6
cpu information            : Intel(R) Pentium(R) CPU  N3700  @ 1.60GHz
gpu card                   : Intel Corporation Atom/Celeron/Pentium Processor x5-E8000/J3xxx/N3xxx Integrated Graphics Controller (rev 21) (prog-if 00 [VGA controller])
memory ram                 : 7.68 GB
max memory ram             : 8 GB
cpu thread                 : 4
cpu core                   : 4
cpu model                  : 76
cpu stepping               : 3
socket                     : Socket BGA1155
signature                  : Type 0, Family 6, Model 76, Stepping 3
hard drive                 : 476GiB (512GB)
current cd clock frequency : 266667 kHz
maximum cd clock frequency : 320000 kHz
displays connected         : DP-1 DP-3


======================================
BXT
======================================
             Software
======================================
kernel version              : 4.13.0-rc2-drm-tip-ww30-commit-1eb8669+
/bin/bash: BXT-3: command not found
architecture                : x86_64
os version                  : Ubuntu 16.10
os codename                 : yakkety
kernel driver               : i915
bios revision               : 5.6
bios release date           : 06/19/2017
ksc                         : 18.0
hardware acceleration       : disabled
swap partition              : enabled on (/dev/sda3)
======================================
        Graphic drivers
======================================
modesetting                 : enabled
modesetting compiled for    : 1.18.4 X.Org Video Driver
xorg-xserver                : 1.18.4
libdrm                    : 2.4.70
libva                       : 1.7.1-2
vaapi (intel-driver)        : 1.7.1
cairo                       : 1.14.6-1build1
intel-gpu-tools             : 1.16-1
======================================
             Hardware
======================================
motherboard model          : NUC6CAYS
motherboard id             : NUC6CAYB
form factor                : Desktop
manufacturer               : Intelcorporation
cpu family                 : Celeron
cpu family id              : 6
cpu information            : Intel(R) Celeron(R) CPU J3455 @ 1.50GHz
gpu card                   : Intel Corporation Device 5a85 (rev 0b) (prog-if 00 [VGA controller])
memory ram                 : 15.54 GB
max memory ram             : 32 GB
cpu thread                 : 4
cpu core                   : 4
cpu model                  : 92
cpu stepping               : 9
socket                     : Other
signature                  : Type 0, Family 6, Model 92, Stepping 9
hard drive                 : 279GiB (300GB)
current cd clock frequency : 288000 kHz
maximum cd clock frequency : 624000 kHz
displays connected         : DP-1 DP-2
Comment 4 Ricardo Madrigal 2017-08-02 16:43:08 UTC
Created attachment 133203 [details]
result.log
Comment 5 Martin Peres 2017-08-02 17:04:21 UTC
So far, we have run into this bug once in 50 runs. It is quite likely an old bug, so the reproduction rate is likely once every thousand runs.

But anyway, no need to bother about reproducing [BAT] bugs, we already have all the data developers may need, including reproducibility rate (not for this one though, because it is really super rare).
Comment 6 vladimir.campos 2017-08-02 19:11:41 UTC
Thanks Martin for your feedback, We will avoid to reproduce [BAT] Bugs, we are cleaning up Bugs that are old and no progress. will take in count your input.
Comment 7 Jani Saarinen 2017-09-01 08:16:57 UTC
Based on CI data: 0 / 153 runs (0 %)
Dropping priority.
Comment 8 Jani Saarinen 2017-09-01 08:19:17 UTC
Not seen in 30 days, closing. 
Lets re-open if seen again.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.