Bug 102191 - Building plymouth-0.9.3 fails with "libply-splash-core/.libs/libply-splash-core.so: undefined reference to `minor'"
Summary: Building plymouth-0.9.3 fails with "libply-splash-core/.libs/libply-splash-co...
Status: RESOLVED FIXED
Alias: None
Product: plymouth
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: medium normal
Assignee: Ray Strode [halfline]
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-13 05:47 UTC by P. Levine
Modified: 2017-08-18 14:12 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
plymouth-0.9.3-sysmacros.patch (342 bytes, patch)
2017-08-13 05:49 UTC, P. Levine
Details | Splinter Review

Description P. Levine 2017-08-13 05:47:26 UTC
Building plymouth-0.9.3 in Gentoo Linux fails with:

> libply-splash-core/.libs/libply-splash-core.so: undefined reference to `minor'
> libply-splash-core/.libs/libply-splash-core.so: undefined reference to `major'

glibc has stated its intent to remove remove <sys/sysmacros.h> from <sys/types.h> (see https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html) .

Gentoo is one of the distros that have patched out such implicit inclusion of <sys/sysmacros.h> from glibc.  <sys/sysmacros.h> needs to be explicitly included in "src/libply-splash-core/ply-terminal.c".

Gentoo bug report: https://bugs.gentoo.org/show_bug.cgi?id=627690
Comment 1 P. Levine 2017-08-13 05:49:52 UTC
Created attachment 133467 [details] [review]
plymouth-0.9.3-sysmacros.patch

Patch taken from https://bugs.gentoo.org/show_bug.cgi?id=627690
Comment 2 Ray Strode [halfline] 2017-08-18 14:12:47 UTC
thanks pushed
To ssh://git.freedesktop.org/git/plymouth
   3a9334e..e12b5ee  master -> master


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.