Created attachment 133497 [details] [review] Add an assignment In the function HandleTouches, the variable new_active_touches is being allocated in a stack, incremented or decremented and then it's being removed from a stack without modifying the actual variable in the structure.
Created attachment 133566 [details] [review] 0001-Drop-HandleTouches-it-s-a-noop.patch Looks like it's not actually needed, UpdateTouchState takes care of this and this whole function is a noop. Can you give this patch a try please? Thanks.
(In reply to Peter Hutterer from comment #1) > Created attachment 133566 [details] [review] [review] > 0001-Drop-HandleTouches-it-s-a-noop.patch > > Looks like it's not actually needed, UpdateTouchState takes care of this and > this whole function is a noop. Can you give this patch a try please? Thanks. I don't actually know how does it affect the behaviour of a pointer. I was working on another problem connected to a particular hardware - https://bugzilla.kernel.org/show_bug.cgi?id=196619 - and during skimming through the code I found that strange function. I've applied the patch, all I can report it doesn't break anything.
thx for testing, I pushed this one a while ago, closing commit 6d3749105d964da5b4e534206fdb47f5ff8a697f Author: Peter Hutterer <> Date: Thu Aug 17 13:10:31 2017 +1000 Drop HandleTouches - it's a noop
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.