From CI_DRM_3078 igt@kms_rotation_crc@sprite-rotation-180-flip fail on HSW and SNB shards. This appear to be a new test that has failed so far on all 3 runs. (kms_rotation_crc:1507) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:345: (kms_rotation_crc:1507) igt-debugfs-CRITICAL: Failed assertion: !mismatch Subtest sprite-rotation-180-flip failed. Full data: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3078/shard-snb4/igt@kms_rotation_crc@sprite-rotation-180-flip.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3078/shard-hsw3/igt@kms_rotation_crc@sprite-rotation-180-flip.html This issue started with: commit af4158671c030c9e7f3fbe9e7e2032d145f86d4d Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Date: Mon Sep 11 18:14:57 2017 +0100 kms_rotation_crc: 90 degree flip test is not a stress test I don't know if it is the intention of this test to exploit an issue or if it is a plain regression.
I asked Tvortko about the issue on IRC: <tursulin_> marta_: kms_rotation_crc failure is expected I'm afraid. Needs debugging to figure out what's wrong in those code paths.
I have also reproduced this on my BDW NUCi5.
Chris, you have reviewed this: Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Chris Wilson <chris@chris-wilson.co.uk> Can you comment what is issue?
New testcases have been added which test previously untested things (which are failing): 1. Do a pageflip to a different frame buffer and then test this CRC. 2. Do it on all planes and not just primary. This passes on primary plane, but fails on sprite.
P.S. On SKL also 90 and 270 orientations fails.
(In reply to Tvrtko Ursulin from comment #5) > P.S. On SKL also 90 and 270 orientations fails. Yep, and on KBL-shards
I noticed that when running the very similar but passing test: ./tests/kms_rotation_crc --run-subtest primary-rotation-180-flip the flip_opacity for the flip case is set to 0.75. However, for the "sprite" version this opacity isn't drawn. If I change the opacity to 1.0 I no longer fail on the crc comparison, but instead I fail on: Test assertion failure function igt_pipe_crc_do_start, file igt_debugfs.c:479: on the second "rectangle_types".
If I remove rotation the test still fails the crc: diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index 21e264ad..1ba64a99 100644 --- a/tests/kms_rotation_crc.c +++ b/tests/kms_rotation_crc.c @@ -677,7 +677,7 @@ igt_main igt_require(!(subtest->rot & (IGT_ROTATION_90 | IGT_ROTATION_270)) || gen >= 9); - data.rotation = subtest->rot; + data.rotation = IGT_ROTATION_0; data.flips = subtest->flips; test_plane_rotation(&data, subtest->plane); also, same I/O error if I change opacity to 1.0.
I will try to find someone who could answer if this is a bug in the test or the driver.
I believe that the name flip_opacity is a mis-representation since drawing is without alpha the overlay is not blended.
The sprite/overlay plane would require blending to be properly setup for the sprite-rotation-*-flip testcases to work in the same manner as the primary-rotation-*-flip. However, since the objective of this test is not to test the blending features of our display engine I will send up a patch that remove those tests.
https://patchwork.freedesktop.org/patch/177668/
According to Ville, above analyze is wrong. The problem is that the drmModePageFlip will only update the primary plane.
It is my intention to fix these tests instead of deleting them.
Maarten has a patch up that fix the tests.
We saw the same issue on GLK QA also... No patch used... Tests List: igt@kms_rotation_crc@sprite-rotation-180-flip This is my configuration: ====================================== Graphic stack ====================================== Component: drm tag: libdrm-2.4.81-56-g7c71188 commit: 7c71188610b4ceba0339c2bc884320bcb749adee Component: cairo tag: 1.15.6-42-gdccbed7 commit: dccbed7d78d32bd3b912e8810379451dd94e6a1f Component: intel-gpu-tools tag: intel-gpu-tools-1.19-332-g0a91a5e commit: 0a91a5e9624d41d23b79e2540eda111cb56d42d9 Component: piglit tag: piglit-v1 commit: 95e2f51a28b6cf7ff77d84e1234121c98f10ef64 ====================================== Software ====================================== kernel version : 4.14.0-rc2-drm-tip-ww39-commit-d76cbbc+ hostname : GLK-2-GLKRVP1DDR405 architecture : x86_64 os version : Ubuntu 16.10 os codename : yakkety kernel driver : i915 bios revision : 62.30 bios release date : 08/22/2017 ksc : 1.41 hardware acceleration : disabled swap partition : enabled on (/dev/sda3) ====================================== Graphic drivers ====================================== grep: /opt/X11R7/var/log/Xorg.0.log: No such file or directory libdrm : 2.4.83 cairo : 1.15.9 intel-gpu-tools (tag) : intel-gpu-tools-1.19-332-g0a91a5e intel-gpu-tools (commit) : 0a91a5e ====================================== Hardware ====================================== platform : Geminilake motherboard model : Geminilake motherboard id : GLKRVP1DDR4(05) form factor : Hand Held manufacturer : IntelCorp. cpu family : Other cpu family id : 6 cpu information : Genuine Intel(R) CPU @ 1.10GHz gpu card : Intel Corporation Device 3185 (rev 03) (prog-if 00 [VGA controller]) memory ram : 3.7 GB max memory ram : 16 GB cpu thread : 2 cpu core : 2 cpu model : 122 cpu stepping : 1 socket : Other hard drive : 111GiB (120GB) current cd clock frequency : 79200 kHz maximum cd clock frequency : 316800 kHz displays connected : eDP-1 DP-1 HDMI-A-2 ====================================== Firmware ====================================== dmc fw loaded : yes dmc version : 1.4 guc fw loaded : SUCCESS guc version wanted : 10.56 guc version found : 10.56 huc fw loaded : yes ====================================== kernel parameters ====================================== quiet drm.debug=0xe pci=pcie_bus_safe i915.alpha_support=1 i915.enable_guc_loading=2 i915.enable_guc_submission=2 intel_iommu=igfx_off auto panic=1 nmi_watchdog=panic resume=/dev/sda3 fastboot
This test are failing on CFL-S-1 QA Tests List: igt@kms_rotation_crc@sprite-rotation-180-flip ==================================================== Output ==================================================== . . . **** DEBUG **** (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.0, fb 82 (kms_rotation_crc:2708) igt-kms-DEBUG: display: src = (0, 0) 1920 x 1080 dst = (0, 0) 1920 x 1080 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.1, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: src = (0, 0) 0 x 0 dst = (0, 0) 0 x 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.2, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: B: Setting NULL mode (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.0, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.1, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.2, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: eDP-1: preparing atomic, pipe: A (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-1: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-2: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: HDMI-A-1: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-3: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: HDMI-A-2: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: } (kms_rotation_crc:2708) DEBUG: Testing case 0 on pipe A (kms_rotation_crc:2708) igt-kms-DEBUG: display: A.1: plane_set_rotation(0°) (kms_rotation_crc:2708) igt-fb-DEBUG: igt_create_fb_with_bo_size(width=1920, height=1080, format=0x34325258, tiling=0x0, size=0) (kms_rotation_crc:2708) igt-fb-DEBUG: igt_create_fb_with_bo_size(handle=2, pitch=7680) (kms_rotation_crc:2708) igt-kms-DEBUG: display: A.1: plane_set_rotation(0°) (kms_rotation_crc:2708) igt-fb-DEBUG: igt_create_fb_with_bo_size(width=1920, height=1080, format=0x34325258, tiling=0x0, size=0) (kms_rotation_crc:2708) igt-fb-DEBUG: igt_create_fb_with_bo_size(handle=3, pitch=7680) (kms_rotation_crc:2708) igt-kms-DEBUG: display: A.1: plane_set_fb(78) (kms_rotation_crc:2708) igt-kms-DEBUG: display: A.1: plane_set_position(0,0) (kms_rotation_crc:2708) igt-kms-DEBUG: display: commit { (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.0, fb 82 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.1, fb 78 (kms_rotation_crc:2708) igt-kms-DEBUG: display: src = (0, 0) 1920 x 1080 dst = (0, 0) 1920 x 1080 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.2, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.0, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.1, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.2, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: eDP-1: preparing atomic, pipe: A (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-1: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-2: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: HDMI-A-1: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-3: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: HDMI-A-2: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: } (kms_rotation_crc:2708) igt-fb-DEBUG: igt_create_fb_with_bo_size(width=1920, height=1080, format=0x34325258, tiling=0x0, size=0) (kms_rotation_crc:2708) igt-fb-DEBUG: igt_create_fb_with_bo_size(handle=4, pitch=7680) (kms_rotation_crc:2708) igt-kms-DEBUG: display: A.1: plane_set_fb(84) (kms_rotation_crc:2708) igt-kms-DEBUG: display: A.1: plane_set_position(0,0) (kms_rotation_crc:2708) igt-kms-DEBUG: display: commit { (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.0, fb 82 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.1, fb 84 (kms_rotation_crc:2708) igt-kms-DEBUG: display: src = (0, 0) 1920 x 1080 dst = (0, 0) 1920 x 1080 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.2, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.0, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.1, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.2, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: eDP-1: preparing atomic, pipe: A (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-1: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-2: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: HDMI-A-1: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-3: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: HDMI-A-2: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: } (kms_rotation_crc:2708) igt-kms-DEBUG: display: A.1: plane_set_fb(76) (kms_rotation_crc:2708) igt-kms-DEBUG: display: A.1: plane_set_position(0,0) (kms_rotation_crc:2708) igt-fb-DEBUG: igt_create_fb_with_bo_size(width=1920, height=1080, format=0x34325258, tiling=0x0, size=0) (kms_rotation_crc:2708) igt-fb-DEBUG: igt_create_fb_with_bo_size(handle=3, pitch=7680) (kms_rotation_crc:2708) igt-kms-DEBUG: display: commit { (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.0, fb 82 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.1, fb 76 (kms_rotation_crc:2708) igt-kms-DEBUG: display: src = (0, 0) 1920 x 1080 dst = (0, 0) 1920 x 1080 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.2, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.0, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.1, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.2, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: eDP-1: preparing atomic, pipe: A (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-1: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-2: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: HDMI-A-1: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-3: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: HDMI-A-2: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: } (kms_rotation_crc:2708) igt-kms-DEBUG: display: A.1: plane_set_rotation(180°) (kms_rotation_crc:2708) igt-kms-DEBUG: display: commit { (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.0, fb 82 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.1, fb 76 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: A.2, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.0, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.1, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: populating plane data: B.2, fb 0 (kms_rotation_crc:2708) igt-kms-DEBUG: display: eDP-1: preparing atomic, pipe: A (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-1: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-2: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: HDMI-A-1: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: DP-3: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: HDMI-A-2: preparing atomic, pipe: None (kms_rotation_crc:2708) igt-kms-DEBUG: display: } (kms_rotation_crc:2708) igt-debugfs-DEBUG: CRC mismatch at index 0: 0xc43b76cb != 0x758e40e1 (kms_rotation_crc:2708) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:345: (kms_rotation_crc:2708) igt-debugfs-CRITICAL: Failed assertion: !mismatch (kms_rotation_crc:2708) igt-core-INFO: Stack trace: (kms_rotation_crc:2708) igt-core-INFO: #0 [__igt_fail_assert+0x101] (kms_rotation_crc:2708) igt-core-INFO: #1 [igt_assert_crc_equal+0x5d] (kms_rotation_crc:2708) igt-core-INFO: #2 [test_plane_rotation+0x713] (kms_rotation_crc:2708) igt-core-INFO: #3 [__real_main634+0xccf] (kms_rotation_crc:2708) igt-core-INFO: #4 [main+0x23] (kms_rotation_crc:2708) igt-core-INFO: #5 [__libc_start_main+0xf1] (kms_rotation_crc:2708) igt-core-INFO: #6 [_start+0x29] (kms_rotation_crc:2708) igt-core-INFO: #7 [<unknown>+0x29] **** END **** . . . This is my configuration: ====================================== Graphic stack ====================================== Component: drm tag: libdrm-2.4.81-56-g7c71188 commit: 7c71188610b4ceba0339c2bc884320bcb749adee Component: cairo tag: 1.15.6-42-gdccbed7 commit: dccbed7d78d32bd3b912e8810379451dd94e6a1f Component: intel-gpu-tools tag: intel-gpu-tools-1.19-334-g2885b10 commit: 2885b10f99b4beeb046e75af8b8488c229f629d3 Component: piglit tag: piglit-v1 commit: e1f66fb2fb8ad781ca755831983b6662c4c440d4 ====================================== Software ====================================== kernel version : 4.14.0-rc2-drm-tip-ww39-commit-85932e1+ hostname : CFL-S-1 architecture : x86_64 os version : Ubuntu 16.10 os codename : yakkety kernel driver : i915 bios revision : 104.3 bios release date : 09/14/2017 ksc : 1.5 hardware acceleration : disabled swap partition : enabled on (/dev/sda3 /dev/nvme0n1p3) ====================================== Graphic drivers ====================================== libdrm : 2.4.83 cairo : 1.15.9 intel-gpu-tools (tag) : intel-gpu-tools-1.19-334-g2885b10 intel-gpu-tools (commit) : 2885b10 ====================================== Hardware ====================================== motherboard model : CoffeeLakeClientPlatform motherboard id : CoffeeLakeSUDIMMRVP form factor : Desktop manufacturer : IntelCorporation cpu family : Other cpu family id : 6 cpu information : Genuine Intel(R) CPU 0000 @ 3.60GHz gpu card : Intel Corporation Device 3e92 (prog-if 00 [VGA controller]) memory ram : 15.58 GB max memory ram : 32 GB cpu thread : 12 cpu core : 6 cpu model : 158 cpu stepping : 10 socket : Other hard drive : 111GiB (120GB) current cd clock frequency : 337500 kHz maximum cd clock frequency : 675000 kHz displays connected : eDP-1 DP-1 ====================================== Firmware ====================================== dmc fw loaded : yes dmc version : 1.1 guc fw loaded : SUCCESS guc version wanted : 9.14 guc version found : 9.14 ====================================== kernel parameters ====================================== quiet drm.debug=0xe pci=pcie_bus_safe intel_iommu=igfx_off auto panic=1 nmi_watchdog=panic i915.alpha_support=1 i915.enable_guc_loading=2 i915.enable_guc_submission=2 resume=/dev/sda3 fastboot
commit 7df7e3bda6a206c15044dfd9804eddeee29d981b (HEAD, origin/master, origin/HEAD) Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Date: Thu Sep 21 12:53:27 2017 +0200 tests: Stop looking at plane private members
This test are passing on GLK QA Tests List: igt@kms_rotation_crc@sprite-rotation-180-flip ==================================================== Output ==================================================== . . . IGT-Version: 1.19-g1e99f8b (x86_64) (Linux: 4.14.0-rc3-drm-tip-ww40-commit-2f14e31+ x86_64) Subtest sprite-rotation-180-flip: SUCCESS (12.699s) . . . This is my configuration: ====================================== Graphic stack ====================================== Component: drm tag: libdrm-2.4.81-57-g1dd84e0 commit: 1dd84e01a972b1759839a7326009be24ab3e6de2 Component: cairo tag: 1.15.6-42-gdccbed7 commit: dccbed7d78d32bd3b912e8810379451dd94e6a1f Component: intel-gpu-tools tag: intel-gpu-tools-1.19-357-g1e99f8b commit: 1e99f8b8d2563d7f5c4e82932bab15abc5eacaef Component: piglit tag: piglit-v1 commit: 5aa6eea37f44f818632a3dad4c1a7478085bd56d ====================================== Software ====================================== kernel version : 4.14.0-rc3-drm-tip-ww40-commit-2f14e31+ hostname : GLK-1-GLKRVP1DDR405 architecture : x86_64 os version : Ubuntu 16.10 os codename : yakkety kernel driver : i915 bios revision : 62.30 bios release date : 08/22/2017 ksc : 1.41 hardware acceleration : disabled swap partition : enabled on (/dev/sda3) ====================================== Graphic drivers ====================================== libdrm : 2.4.83 cairo : 1.15.9 intel-gpu-tools (tag) : intel-gpu-tools-1.19-357-g1e99f8b intel-gpu-tools (commit) : 1e99f8b ====================================== Hardware ====================================== platform : Geminilake motherboard model : Geminilake motherboard id : GLKRVP1DDR4(05) form factor : Hand Held manufacturer : IntelCorp. cpu family : Other cpu family id : 6 cpu information : Genuine Intel(R) CPU @ 1.10GHz gpu card : Intel Corporation Device 3185 (rev 03) (prog-if 00 [VGA controller]) memory ram : 7.64 GB max memory ram : 16 GB cpu thread : 2 cpu core : 2 cpu model : 122 cpu stepping : 1 socket : Other hard drive : 223GiB (240GB) current cd clock frequency : 316800 kHz maximum cd clock frequency : 316800 kHz displays connected : eDP-1 DP-1 HDMI-A-2 ====================================== Firmware ====================================== dmc fw loaded : yes dmc version : 1.4 guc fw loaded : SUCCESS guc version wanted : 10.56 guc version found : 10.56 ====================================== kernel parameters ====================================== quiet drm.debug=0x1e pci=pcie_bus_safe intel_iommu=igfx_off auto panic=1 nmi_watchdog=panic i915.alpha_support=1 i915.enable_guc_loading=2 i915.enable_guc_submission=2 resume=/dev/sda3 fastboot ...when this test mark as pass will removed from the list...
Closing then. :)
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.