Bug 103007 - [OpenGL CTS] [HSW] KHR-GL45.gpu_shader_fp64.fp64.max_uniform_components fails
Summary: [OpenGL CTS] [HSW] KHR-GL45.gpu_shader_fp64.fp64.max_uniform_components fails
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Plamena Manolova
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 102590
  Show dependency treegraph
 
Reported: 2017-09-27 07:37 UTC by Kenneth Graunke
Modified: 2017-11-30 07:05 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Graunke 2017-09-27 07:37:01 UTC
KHR-GL45.gpu_shader_fp64.fp64.max_uniform_components fails on Haswell.  Transform feedback seems to be incorrect for dmat types.
Comment 1 Iago Toral 2017-11-30 07:05:26 UTC
Fixed in master with:

commit 8620f7ebbc763dc1bbbc825d31cacfdd84433e05
Author: Iago Toral Quiroga <itoral@igalia.com>
Date:   Wed Nov 29 10:50:42 2017 +0100

    i965/vec4: use a temp register to compute offsets for pull loads
    
    64-bit pull loads are implemented by emitting 2 separate
    32-bit pull load messages, where the second message loads from
    an offset at +16B.
    
    That addition of 16B to the original offset should not alter the
    original offset register used as source for the pull load instruction
    though, since the compiler might use that same offset register in other
    instructions (for example, for other pull loads in the shader code
    that take that same offset as reference).
    
    If the pull load is 32-bit then we only need to emit one message and
    we don't need to do offset calculations, but in that case the optimizer
    should be able to drop the redundant MOV.
    
    Fixes the following test on Haswell:
    KHR-GL45.gpu_shader_fp64.fp64.max_uniform_components
    
    Reviewed-by: Matt Turner <mattst88@gmail.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103007


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.