Bug 103041 - [PATCH] Arthur: implement rudimentary drawSoftMaskedImage method
Summary: [PATCH] Arthur: implement rudimentary drawSoftMaskedImage method
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: arthur backend (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-29 19:48 UTC by oliver.sander
Modified: 2017-10-05 16:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch that implements drawSoftMaskedImage (4.28 KB, patch)
2017-09-29 19:48 UTC, oliver.sander
Details | Splinter Review
Example file that needs the new patch (70.79 KB, application/pdf)
2017-09-29 19:49 UTC, oliver.sander
Details
Patch that fixes the original patch (1.10 KB, patch)
2017-10-02 22:08 UTC, oliver.sander
Details | Splinter Review

Description oliver.sander 2017-09-29 19:48:39 UTC
Created attachment 134571 [details] [review]
Patch that implements drawSoftMaskedImage

Currently, the Arthur backend does not implement the drawSoftMaskedImage method. In particular, this leads to alpha values being tacitly ignored when images have them.  This patch implements the method, and therewith fixes rendering of images with an alpha channel (an example is attached).

I suppose that the implementation is not as general as it should be, but without further test documents I have not clue how exactly it needs to be generalized.
Comment 1 oliver.sander 2017-09-29 19:49:27 UTC
Created attachment 134572 [details]
Example file that needs the new patch
Comment 2 Albert Astals Cid 2017-09-30 20:58:37 UTC
pushed
Comment 3 oliver.sander 2017-10-02 22:07:29 UTC
The patch is missing the 'return' statements in the error path.  Please apply the attached patch on top of it.  Apologies for mistake!
Comment 4 oliver.sander 2017-10-02 22:08:15 UTC
Created attachment 134627 [details] [review]
Patch that fixes the original patch
Comment 5 Albert Astals Cid 2017-10-05 16:46:29 UTC
pushed, you're lucky i broke 0.60.0 and thus i need to release 0.60.1 today


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.