This test was enabled with mesa
Author: Matt Turner <firstname.lastname@example.org>
docs: GL_ARB_indirect_parameters is now supported on i965/gen7+
From the comment it appears that these tests should pass on the specified platforms.
HSW intermittently fails these tests, and they have been disabled for HSW in CI.
When run by itself, the test passes consistently for me on both Ivybridge and Haswell. However, I can easily reproduce failures by doing:
$ while true; do ./bin/arb_indirect_parameters-tf-count-arrays -auto -fbo; done
and at the same time doing:
$ while true; do ./bin/nv_conditional_render-copypixels -auto -fbo; done
My guess is there's something going awry when multiple concurrent programs are trying to use predicated rendering...
I can reproduce these failures too using the method Ken described. I'll take a closer look and investigate.
This patch fixes this bug: https://patchwork.freedesktop.org/patch/184754/
Author: Plamena Manolova <email@example.com>
Date: Mon Oct 30 21:14:24 2017 +0000
i965: Fix ARB_indirect_parameters logic.
This patch modifies the ARB_indirect_parameters logic in
brw_draw_prims, so that our implementation isn't affected if
another application attempts to use predicates. Previously we
were using a predicate with a DELTAS_EQUAL comparison operation
and relying on the MI_PREDICATE_DATA register being 0. Our code
to initialize MI_PREDICATE_DATA to 0 was incorrect, so we were
accidentally using whatever value was written there. Because the
kernel does not initialize the MI_PREDICATE_DATA register on
hardware context creation, we might inherit the value from whatever
context was last running on the GPU (likely another process).
The Haswell command parser also does not currently allow us to write
the MI_PREDICATE_DATA register. Rather than fixing this and requiring
an updated kernel, we switch to a different approach which uses a
SRCS_EQUAL predicate that makes no assumptions about the states of any
of the predicate registers.
Fixes Piglit's spec/arb_indirect_parameters/tf-count-arrays test.
Signed-off-by: Plamena Manolova <firstname.lastname@example.org>
Reviewed-by: Kenneth Graunke <email@example.com>