Bug 103117 - [PATCH] Cleanup in ArthurOutputDev::updateFont
Summary: [PATCH] Cleanup in ArthurOutputDev::updateFont
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: arthur backend (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-05 21:44 UTC by oliver.sander
Modified: 2019-09-01 10:48 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
The patch (6.00 KB, patch)
2017-10-05 21:44 UTC, oliver.sander 		Details | Splinter Review
View All

Description oliver.sander 2017-10-05 21:44:35 UTC 
Created attachment 134693 [details] [review]
The patch

The attached patch contains a bit of cleanup in the updateFont method of the ArthurOutputDev class, in the wake of cc43c720e857548175a9e35b0686a1a7a8957f50 .  

In particular, it does

- remove some goto-style error handling
- use nullptr
- use std::unique_ptr (fixes a leak)
- remove unused data member m_currentFont
- remove some unused forward declarations
Comment 1 Albert Astals Cid 2017-10-22 21:23:23 UTC 
Pushed
Comment 2 Sayedjumaasalam 2019-09-01 10:48:46 UTC 
Try simply starting. There is a bin dir, with the scilab executable in in.
https://www.icreseda.com/ With nouveau on my hardware I already get issues at this point .

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.