Bug 103212 - [PATCH] Add OpenGL 4.6 as a known version
Summary: [PATCH] Add OpenGL 4.6 as a known version
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Demos (show other bugs)
Version: unspecified
Hardware: All All
: medium trivial
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-11 09:19 UTC by Dario Ostuni
Modified: 2017-10-11 20:43 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch to add OpenGL 4.6 as a known version (349 bytes, patch)
2017-10-11 09:19 UTC, Dario Ostuni
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Dario Ostuni 2017-10-11 09:19:07 UTC
Created attachment 134788 [details] [review]
Patch to add OpenGL 4.6 as a known version

src/xdemos/glinfo_common.h contains a list of known OpenGL versions, this patch add OpenGL 4.6
Comment 1 Eric Engestrom 2017-10-11 13:26:02 UTC
Good catch, thanks! This allows glxinfo and wglinfo to show 4.6 info :)

I went ahead and create a commit for you, and pushed it:

commit 22bc355f1b324b6ea07e063b5f20be757ea7a8e5
Author: Dario Ostuni <dario.ostuni@gmail.com>
Date:   Wed Oct 11 14:12:58 2017 +0100

    Add OpenGL 4.6 as a known version
    
    Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

Next time you have a patch, it would be easier if you sent it to the mailing list instead.
Everything you need to know is explained on our website:
https://mesa3d.org/submittingpatches.html
Comment 2 Emil Velikov 2017-10-11 15:53:12 UTC
(In reply to Eric Engestrom from comment #1)
> Good catch, thanks! This allows glxinfo and wglinfo to show 4.6 info :)
> 
It should work even without the patch. When requesting GL 4.5 (or 3.1 even) the driver is allowed to create a 4.6 context since it's compatible with the requested version.

Regardless, it's a good idea to be explicit imho.
Comment 3 Dario Ostuni 2017-10-11 16:05:07 UTC
@Eric Engestrom thanks! And also thanks for pointing me to that page in the website.

@Emil Velikov with the NVIDIA proprietary driver glxinfo was showing OpenGL version 4.5, even if the driver supports 4.6
Comment 4 Ian Romanick 2017-10-11 20:43:03 UTC
(In reply to Dario Ostuni from comment #3)
> @Emil Velikov with the NVIDIA proprietary driver glxinfo was showing OpenGL
> version 4.5, even if the driver supports 4.6

That is probably because OpenGL 4.6 is still only a provisional specification (due to no conformance program yet).  Once the conformance program is in place and 4.6 support moves out of beta, I bet it would just work.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.