Bug 103590 - CMake: ENABLE_GLIB vs. WITH_GLIB
Summary: CMake: ENABLE_GLIB vs. WITH_GLIB
Status: RESOLVED MOVED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-06 10:58 UTC by Roland Hieber
Modified: 2018-08-21 10:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
CMake: remove ENABLE_GLIB in favour of WITH_GLIB from macro_optional_find_package(GLIB) (2.19 KB, patch)
2017-11-06 10:58 UTC, Roland Hieber 		Details | Splinter Review
View All

Description Roland Hieber 2017-11-06 10:58:23 UTC 
Created attachment 135254 [details] [review]
CMake: remove ENABLE_GLIB in favour of WITH_GLIB from macro_optional_find_package(GLIB)

When configuring poppler 0.60.1 with ccmake, I can see both ENABLE_GLIB and (further down) WITH_GLIB. As I understand the code, both of them need to be set for GLIB to be used. Since WITH_GLIB is the guard used in `macro_optional_find_package(GLIB)`, I think that `ENABLE_GLIB` can be spared. See the attached patch, which works for me.
Comment 1 Albert Astals Cid 2017-11-06 20:54:53 UTC 
This breaks people's cmake calls, i don't see a need for that tbh.
Comment 2 GitLab Migration User 2018-08-21 10:35:02 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/272.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.