Created attachment 135254 [details] [review]
CMake: remove ENABLE_GLIB in favour of WITH_GLIB from macro_optional_find_package(GLIB)
When configuring poppler 0.60.1 with ccmake, I can see both ENABLE_GLIB and (further down) WITH_GLIB. As I understand the code, both of them need to be set for GLIB to be used. Since WITH_GLIB is the guard used in `macro_optional_find_package(GLIB)`, I think that `ENABLE_GLIB` can be spared. See the attached patch, which works for me.
This breaks people's cmake calls, i don't see a need for that tbh.
-- GitLab Migration Automatic Message --
This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/272.