Bug 1041 - xf86RandRSetMode calls wrong EnableDisableFBAccess
Summary: xf86RandRSetMode calls wrong EnableDisableFBAccess
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: All All
: high normal
Assignee: Xorg Project Team
QA Contact:
Depends on:
Blocks: 351
  Show dependency treegraph
Reported: 2004-08-11 11:13 UTC by Aaron Plattner
Modified: 2004-08-12 18:27 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Use scrp->EnableDisableFBAccess instead of xf86EnableDisableFBAccess (840 bytes, patch)
2004-08-11 11:15 UTC, Aaron Plattner
no flags Details | Splinter Review

Description Aaron Plattner 2004-08-11 11:13:36 UTC
In xf86RandRSetMode, xf86EnableDisableFBAccess is used instead of the function pointer in the  
ScrnInfoRec.  This bypasses a lot of the call chain, which leads to problems.
Comment 1 Aaron Plattner 2004-08-11 11:15:00 UTC
Created attachment 608 [details] [review]
Use scrp->EnableDisableFBAccess instead of xf86EnableDisableFBAccess
Comment 2 Søren Sandmann Pedersen 2004-08-13 11:27:59 UTC
Fri Aug 13 19:53:10 2004  Soeren Sandmann  <sandmann@redhat.com>

	* programs/Xserver/hw/xfree86/drivers/mga/mga_storm.c
	(MGAStormSync): Fix for lockups on some versions of Matrox
	Mystique. #687, Patch from Mike Harris.

	* programs/Xserver/hw/xfree86/common/xf86RandR.c
	(xf86RandRSetMode): Call xf86EnableDisableFBAccess though the
	function pointer instead of directly. #1041, Patch from Aaron Plattner.

	* programs/Xserver/hw/xfree86/common/xf86RandR.c: Swap the
	phsyical size of the screen when rotiation. #1050, Patch from
	Aaron Plattner.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.