Bug 104263 - Qt5: Add cancellation support to renderToImage and textList
Summary: Qt5: Add cancellation support to renderToImage and textList
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: qt frontend (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-14 14:09 UTC by Albert Astals Cid
Modified: 2018-02-01 21:47 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Qt5 cancellable support (16.34 KB, patch)
2017-12-14 14:09 UTC, Albert Astals Cid 		Details | Splinter Review
Qt5 cancellable support (16.36 KB, patch)
2018-01-19 15:44 UTC, Albert Astals Cid 		Details | Splinter Review
Show Obsolete (1) View All

Description Albert Astals Cid 2017-12-14 14:09:49 UTC 
Created attachment 136172 [details] [review]
Qt5 cancellable support

The attached patch uses the already existant support in Gfx.cc to be able to cancel a renderToImage or textList if the user is no longer interested in it.
Comment 1 Albert Astals Cid 2018-01-15 09:11:28 UTC 
FWIW i have work-work-time assigned for this, but as far as i understand only this month, so it would be great if anyone could find time to review this *now* so i can put the time to do changes *now* too and not when i find hobby-time.

OTOH not much people review my code so i may as well just commit it at some point

P.S: This is needed by https://phabricator.kde.org/D9328
Comment 2 oliver.sander 2018-01-15 13:38:18 UTC 
The patch contains a new textList method.  That's unrelated and should go into a separate patch, right?
Comment 3 Albert Astals Cid 2018-01-15 18:44:35 UTC 
No, it's not unrelated, the patch is " Qt5: Add cancellation support to renderToImage and *textList*"
Comment 4 oliver.sander 2018-01-15 19:16:47 UTC 
Indeed.  Apologies for wasting your time.
Comment 5 Albert Astals Cid 2018-01-19 15:44:00 UTC 
Created attachment 136850 [details] [review]
Qt5 cancellable support

new version of the patch that applies to master as of today
Comment 6 Albert Astals Cid 2018-02-01 21:47:30 UTC 
pushed

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.