Bug 104265 - pkgconfig file bindir not expanded
Summary: pkgconfig file bindir not expanded
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.12
Hardware: All All
: medium normal
Assignee: D-Bus Maintainers
QA Contact: D-Bus Maintainers
Whiteboard: review+
Keywords: patch
Depends on:
Reported: 2017-12-14 14:33 UTC by Benedikt Heine
Modified: 2017-12-14 16:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Resolve bindir variable in dbus-1.pc (782 bytes, patch)
2017-12-14 14:33 UTC, Benedikt Heine
Details | Splinter Review

Description Benedikt Heine 2017-12-14 14:33:43 UTC
Created attachment 136173 [details] [review]
Resolve bindir variable in dbus-1.pc

In pkg-config, the bindir variable is not expanded for the daemondir correctly.

pkg-config dbus-1 --variable=daemondir reports simply $bindir (which actually should be the expanded to the variable value of ${bindir}).

This patch just adds braces, that pkg-config resolves the variable correct.
Comment 1 Simon McVittie 2017-12-14 14:57:53 UTC
Thanks, makes sense.
Comment 2 Simon McVittie 2017-12-14 15:58:50 UTC
Fixed in git for 1.12.4, 1.13.0. Thanks!
Comment 3 Benedikt Heine 2017-12-14 16:02:55 UTC
Wow, that was fast! Thank you, Simon.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.