Bug 10429 - attempts to assign a NULL volume.fstype
Summary: attempts to assign a NULL volume.fstype
Status: RESOLVED FIXED
Alias: None
Product: hal
Classification: Unclassified
Component: hald (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: Danny Kukawka
QA Contact:
URL: https://launchpad.net/ubuntu/+source/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-27 10:41 UTC by Martin Pitt
Modified: 2007-04-18 12:26 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
possible fix (2.10 KB, patch)
2007-03-29 11:17 UTC, Danny Kukawka 		Details | Splinter Review
View All

Description Martin Pitt 2007-03-27 10:41:01 UTC 
In the Ubuntu bug report above we got a crash in hald-probe-volume when trying to assign NULL to volume.fstype. The debug stack trace at

  https://launchpad.net/ubuntu/+source/hal/+bug/87800/comments/2

pinpoints the issue pretty well. However, I'm not entirely sure at which level this should be fixed. Just set it to an empty string?
Comment 1 Martin Pitt 2007-03-27 10:52:42 UTC 
Hm, just setting it to the empty string might make it crash on the next NULL field, so this is not just an one-line patch.
Comment 2 Danny Kukawka 2007-03-29 11:17:59 UTC 
Created attachment 9359 [details] [review]
possible fix

Does this patch help? Let me know to get this into 0.5.9
Comment 3 Martin Pitt 2007-03-30 08:11:48 UTC 
Uploaded into Ubuntu, I asked the reporter for feedback.
Comment 4 Danny Kukawka 2007-04-18 12:26:50 UTC 
commited to git HEAD and 0.5.9 branch

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.