Bug 104320 - blacklist: include Pycom devices
Summary: blacklist: include Pycom devices
Status: RESOLVED FIXED
Alias: None
Product: ModemManager
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: ModemManager bug user
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-18 13:35 UTC by Serge Stroobandt
Modified: 2017-12-18 23:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Serge Stroobandt 2017-12-18 13:35:53 UTC
Please, add the following lines to src/77-mm-usb-device-blacklist.rules

    # All devices from Pycom LTD
    # Since Pycom is not producing any modems, it is safe to blacklist all Pycom LTD devices.
    ATTRS{idVendor}=="04d8", ENV{ID_MM_DEVICE_IGNORE}="1"

References:
https://forum.pycom.io/topic/1418/failed-to-set-dtr-rts/10
https://github.com/pycom/pycom-micropython-sigfox/issues/69
Comment 1 Aleksander Morgado 2017-12-18 14:39:24 UTC
Thanks, pushed to git master, mm-1-6 and mm-1-4.
Comment 2 Serge Stroobandt 2017-12-18 21:35:42 UTC
As per https://forum.pycom.io/topic/1418/failed-to-set-dtr-rts/17#
the Pycom blacklist requires idProducts anyway.

Here are the first two. I am waiting for more.

# Pycom Pysense
ATTRS{idVendor}=="04d8", ATTRS{idProduct}=="f012", ENV{ID_MM_DEVICE_IGNORE}="1"

# Pycom Pytrack
ATTRS{idVendor}=="04d8", ATTRS{idProduct}=="f013", ENV{ID_MM_DEVICE_IGNORE}="1"
Comment 3 Aleksander Morgado 2017-12-18 21:43:15 UTC
(In reply to Serge Stroobandt from comment #2)
> As per https://forum.pycom.io/topic/1418/failed-to-set-dtr-rts/17#
> the Pycom blacklist requires idProducts anyway.
> 
> Here are the first two. I am waiting for more.
> 
> # Pycom Pysense
> ATTRS{idVendor}=="04d8", ATTRS{idProduct}=="f012",
> ENV{ID_MM_DEVICE_IGNORE}="1"
> 
> # Pycom Pytrack
> ATTRS{idVendor}=="04d8", ATTRS{idProduct}=="f013",
> ENV{ID_MM_DEVICE_IGNORE}="1"

No, why?

The devices are already blacklisted by the VID, there shouldn't be any need to also use PID in addition to just the VID.
Comment 4 Aleksander Morgado 2017-12-18 21:45:11 UTC
Ah! it's Microchip's VID... gah
Comment 5 Aleksander Morgado 2017-12-18 21:58:27 UTC
I've pushed the 2 blacklisted devices with rules including vid:pid, but I've also added the whole vid to the "usb adapters greylist", which are only probed if manually requested to do so, so should help to avoid interference with other Microchip-vid-tagged devices.

https://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=c2b956aefce495865cbdcb9971e2b3cd99cd0e99
Comment 6 Serge Stroobandt 2017-12-18 22:11:16 UTC
OK, it will be just these two products, so far.
Pycom engineers will take care of reporting any future devices over here.
See also: https://forum.pycom.io/topic/1418/failed-to-set-dtr-rts/23#
Comment 7 Aleksander Morgado 2017-12-18 23:11:00 UTC
(In reply to Serge Stroobandt from comment #6)
> OK, it will be just these two products, so far.
> Pycom engineers will take care of reporting any future devices over here.
> See also: https://forum.pycom.io/topic/1418/failed-to-set-dtr-rts/23#

On the next MM 1.8 stable release we're going to release a mechanism that should allow avoiding the need of the blacklist all together, and making MM not touch those kind of TTYs.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.