Bug 104390 - poppler-uninstalled.pc etc
Summary: poppler-uninstalled.pc etc
Status: RESOLVED MOVED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium enhancement
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-27 01:17 UTC by suzuki toshiya
Modified: 2018-08-21 10:42 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
a patch to restore xxx-uninstalled.pc files (3.71 KB, patch)
2017-12-27 01:17 UTC, suzuki toshiya
Details | Splinter Review
a patch to restore xxx-uninstalled.pc files (rev1) (4.10 KB, patch)
2018-01-28 08:59 UTC, suzuki toshiya
Details | Splinter Review

Description suzuki toshiya 2017-12-27 01:17:28 UTC
Created attachment 136399 [details] [review]
a patch to restore xxx-uninstalled.pc files

Since poppler-0.60.0, the uninstalled pkg-config files (like poppler-uninstalled.pc)
are removed. Here is a patch to restore them.
Comment 1 Albert Astals Cid 2018-01-28 00:43:06 UTC
poppler-uninstalled.pc.cmake file missing?

Also no includes/libs for poppler-cairo-uninstanlled and poppler-splash-uninstalled?
Comment 2 suzuki toshiya 2018-01-28 08:59:40 UTC
Created attachment 137004 [details] [review]
a patch to restore xxx-uninstalled.pc files (rev1)

oh, sorry for my mistaken in the submission. here is corrected one.

the lack of libs in poppler-cairo-uinstalled and poppler-splash-uninstalled are
because cmake build system no longer creates libsplash and libpoppler-cairo.
therefore, normal poppler-splash.pc and poppler-cairo.pc have no libs anymore.

the lack of includes in poppler-cairo-uninstalled and poppler-splash-uninstalled are
same with the uninstalled pc files of the last revision (please find the changeset of
851bc59c6f4b007333d064af5c6992702b92cdf6 ).

But, reconsidering their designs again, I guess, no includes for poppler-cairo is not
problematic (because they are almost samely compiled with other poppler
sources under poppler/ subdirectory), but no includes for poppler-splash might
be problematic because the related headers are collected in splash/ subdirectory.

Although I uploaded corrected patch (to clarify what I wanted to propose), but
now I think more discussion is needed to decide how to handle poppler-splash
and poppler-cairo modules in future. please let discuss in the mailing list.
Comment 3 GitLab Migration User 2018-08-21 10:42:17 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/335.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.