Bug 104674 - #include <ctime> is missing in poppler/Form.h
Summary: #include <ctime> is missing in poppler/Form.h
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All FreeBSD
: medium major
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-17 12:49 UTC by Mojca Miklavec
Modified: 2018-01-18 07:33 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
The trivial patch (575 bytes, patch)
2018-01-17 19:34 UTC, oliver.sander 		Details | Splinter Review
View All

Description Mojca Miklavec 2018-01-17 12:49:43 UTC 
Poppler fails to compile on FreeBSD due to a missing <ctime> header:

error: unknown type name 'time_t'

Can you please add "#include <ctime>" to poppler/Form.h?

See http://www.cplusplus.com/reference/ctime/time_t/
Comment 1 oliver.sander 2018-01-17 19:34:05 UTC 
Created attachment 136812 [details] [review]
The trivial patch
Comment 2 Albert Astals Cid 2018-01-17 21:34:13 UTC 
used time.h
Comment 3 Mojca Miklavec 2018-01-18 07:33:56 UTC 
While it's ok to use "time.h", this is usually done in C. For C++ (and given the fact that the header includes <vector>, it cannot be used in C anyway) it's nicer to use <ctime>.

Anyway, the current patch should work as well, thank you very much.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.