Created attachment 136872 [details] [review]
[PATCH 1/4] pixel-buffer: Add the concept of device rotation
On some devices the LCD panel is mounted in the casing in such a way that
the up/top side of the panel does not match with the top side of the
Examples of this are:
-Tablets where the LCD panel is mounted upside-down (various models)
-Clamshell design devices use portrait tablet screens in a landscape fashion /
a landscape case, e.g. the GPD pocket, GPD win, Asus T100HA and the VIOS LTH17
(so the didplay is mounted rotated 90 degrees clock-wise or counter-clock-wise).
Starting with kernel 4.16 there is code in the kernel to:
-Detect affected devices
-Automatically rotate the fbconsole to compensate
-Let userspace know about this with a new "panel orientation" property on the drm connector of the panel
The patch series I'm attaching to this bug adds support for this to plymouth, so that the boot-splash and diskcrypt-ask-password are shown with the correct orientation / the right way up on these devices.
I'm also attach an alternative more involved fix for the issue the last patch solves. But I think the simpler fix is better.
Created attachment 136873 [details] [review]
[PATCH 2/4] drm: Check for "panel orientation" connector property
Created attachment 136874 [details] [review]
[PATCH 3/4] drm: Reset primary plane rotation to DRM_MODE_ROTATE_0
Created attachment 136875 [details] [review]
[PATCH 4/4] main: Do not update the display on backspace when there is no input to remove
Created attachment 136876 [details] [review]
Alternative patch for [PATCH 4/4] main: Do not update the display on backspace when there is no input to remove
Hey sorry, I don't think I'm going to get the time to do a full, in-depth review of this, but
you've been patiently waiting, and they superficially look okay, so i'm going to just push them now.
Thanks for the work on this !