Bug 104846 - PyXDG missing icon scale support
Summary: PyXDG missing icon scale support
Status: RESOLVED FIXED
Alias: None
Product: PyXDG
Classification: Unclassified
Component: PyXDG (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Thomas Kluyver
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-30 04:00 UTC by Yaakov Selkowitz
Modified: 2018-02-05 10:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Yaakov Selkowitz 2018-01-30 04:00:36 UTC
PyXDG testsuite fails with hicolor-icon-theme 0.17 due to the addition of icon scale support (bug 102330):

======================================================================
ERROR: test_validate_icon_theme (test-icon.IconThemeTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/pyxdg-0.25/test/test-icon.py", line 20, in test_validate_icon_theme
    theme.validate()
  File "/builddir/build/BUILD/pyxdg-0.25/xdg/IniFile.py", line 231, in validate
    raise ValidationError(msg, self.filename)
ValidationError: ValidationError in file '/usr/share/icons/hicolor/index.theme': 
- Invalid key: Scale
- Invalid key: Scale
- Invalid key: Scale
[snip]
----------------------------------------------------------------------
Ran 36 tests in 3.488s
FAILED (errors=1)
Comment 1 Thomas Kluyver 2018-02-02 14:31:42 UTC
Thanks, fixed in this commit:
https://cgit.freedesktop.org/xdg/pyxdg/commit/?id=056dbc12ed21abf601609751eee117a06d3d26a7

I also noticed that there's a 'ScaledDirectories' key in the overview section, so I added that too. Can you see anything else that it's missing?
Comment 2 Yaakov Selkowitz 2018-02-02 17:22:41 UTC
This is all of which I am aware, only because the testsuite failed.
Comment 3 Thomas Kluyver 2018-02-05 10:54:44 UTC
OK, version 0.26 is out, and should fix this.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.