Bug 104996 - daemon: don't return account expiration policy if not known
Summary: daemon: don't return account expiration policy if not known
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-07 16:11 UTC by Ray Strode [halfline]
Modified: 2018-02-07 16:11 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
daemon: don't return account expiration policy if not known (7.45 KB, patch)
2018-02-07 16:11 UTC, Ray Strode [halfline]
Details | Splinter Review

Description Ray Strode [halfline] 2018-02-07 16:11:13 UTC
Right now we assume the user's shadow entry will always be available.
If it's not available, we return fields from it initialized to 0.

That leads to spurious password expired notifications in GNOME.

This commit throws a NOT_SUPPORTED error if the shadow file is off
limits.
Comment 1 Ray Strode [halfline] 2018-02-07 16:11:19 UTC
Created attachment 137217 [details] [review]
daemon: don't return account expiration policy if not known
Comment 2 Ray Strode [halfline] 2018-02-07 16:11:27 UTC
Attachment 137217 [details] pushed as 245d31d - daemon: don't return account expiration policy if not known


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.