Bug 10541 - Improve Module Default Handling
Summary: Improve Module Default Handling
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other All
: medium enhancement
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-05 20:08 UTC by David Nusinow
Modified: 2007-05-03 19:04 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Module Defaults Patch (9.13 KB, patch)
2007-04-05 20:09 UTC, David Nusinow
no flags Details | Splinter Review
Improved Module Default Handling (8.95 KB, patch)
2007-04-14 09:39 UTC, David Nusinow
no flags Details | Splinter Review

Description David Nusinow 2007-04-05 20:08:22 UTC
I've not been happy with the way the server deals with modules. Currently, it loads a default set if none are specified, but if one is specified, that's the only one that gets loaded.

A better system is a set of defaults that can be individually overridden without breaking the other defaults. So if you want to have the server load an additional module, then you only have to specify that one module, making your xorg.conf easier to read.

The attached patch should implement this. I'd like to get it signed off before I commit it. It works fine on my system, but I'm obviously still a novice when it comes to hacking the server. A potentially important issue is that it uses a C99 specific feature to actually set the defaults in a header file. I think this improves the readability of the code quite a bit, and makes it easy for someone to change the defaults. If C99 isn't ok, I'd appreciate ideas on how to set the defaults instead. Thanks!
Comment 1 David Nusinow 2007-04-05 20:09:15 UTC
Created attachment 9492 [details] [review]
Module Defaults Patch

There's no documentation in this patch beyond code comments. Once this feature goes in, I plan to document the defaults in a manpage somewhere.
Comment 2 David Nusinow 2007-04-14 09:39:04 UTC
Created attachment 9606 [details] [review]
Improved Module Default Handling

Updated patch. This changes the directive from "NoLoad" (which is an abomination) to "Disable". It also adds some small bit of documentation. I still need to document the default modules in the manpage. I'll be applying this in Debian, so if all goes well there I'll be applying it to master too.
Comment 3 David Nusinow 2007-05-03 19:04:41 UTC
Fix pushed to master


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.