Bug 105450 - [CI] igt@kms_frontbuffer_tracking@*psr* - fail - Failed assertion: !psr_is_enabled() - PSR still enabled
Summary: [CI] igt@kms_frontbuffer_tracking@*psr* - fail - Failed assertion: !psr_is_en...
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: DRI git
Hardware: Other All
: high normal
Assignee: Dhinakaran Pandiyan
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: ReadyForDev
Keywords:
: 104466 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-03-12 10:19 UTC by Marta Löfstedt
Modified: 2018-08-01 12:48 UTC (History)
3 users (show)

See Also:
i915 platform: CFL, CNL, GLK, KBL, SKL
i915 features: display/PSR


Attachments

Description Marta Löfstedt 2018-03-12 10:19:29 UTC
Note, we are now pulling in data from full CI runs from CNL and CFL BAT machines.  Also this is not the same result as bug 103345

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3903/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html

(kms_frontbuffer_tracking:1778) CRITICAL: Test assertion failure function do_status_assertions, file kms_frontbuffer_tracking.c:1861:
(kms_frontbuffer_tracking:1778) CRITICAL: Failed assertion: !psr_is_enabled()
(kms_frontbuffer_tracking:1778) CRITICAL: PSR still enabled
Subtest psr-rgb101010-draw-mmap-gtt failed.
Comment 2 Dhinakaran Pandiyan 2018-03-20 17:13:59 UTC
Expected failure, as we don't modify the debugfs active flag on frontbuffer flush. Let's lower the priority on this as I am already working on a fix and PSR is not enabled by default.
Comment 3 Marta Löfstedt 2018-03-21 06:47:42 UTC
(In reply to Dhinakaran Pandiyan from comment #2)
> Expected failure, as we don't modify the debugfs active flag on frontbuffer
> flush. Let's lower the priority on this as I am already working on a fix and
> PSR is not enabled by default.

Since this is on CFL-u my guess is that priority will soon be higher...
Comment 4 Hector Velazquez 2018-03-23 22:09:02 UTC
This tests has a failed on CNL QA 
Tests List:
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@fbcpsr-2p-indfb-fliptrack
igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@fbcpsr-farfromfence
igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-farfromfence
igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt


software:
IGT-Version: 1.22-gc30e331 (x86_64) (Linux: 4.16.0-rc6-drm-intel-qa-ww12-commit-dff9ece+ x86_64)

Output sample:
(kms_frontbuffer_tracking:891) CRITICAL: Test assertion failure function do_status_assertions, file kms_frontbuffer_tracking.c:1764:
(kms_frontbuffer_tracking:891) CRITICAL: Failed assertion: !psr_is_enabled()
(kms_frontbuffer_tracking:891) CRITICAL: PSR still enabled
(kms_frontbuffer_tracking:891) igt-core-INFO: Stack trace:
(kms_frontbuffer_tracking:891) igt-core-INFO:   #0 [__igt_fail_assert+0x101]
(kms_frontbuffer_tracking:891) igt-core-INFO:   #1 [__do_assertions+0x606]
(kms_frontbuffer_tracking:891) igt-core-INFO:   #2 [draw_subtest+0x12d]
(kms_frontbuffer_tracking:891) igt-core-INFO:   #3 [main+0x1442]
(kms_frontbuffer_tracking:891) igt-core-INFO:   #4 [__libc_start_main+0xf1]
(kms_frontbuffer_tracking:891) igt-core-INFO:   #5 [_start+0x29]
(kms_frontbuffer_tracking:891) igt-core-INFO:   #6 [<unknown>+0x29]
Comment 6 Hector Velazquez 2018-04-12 15:00:13 UTC
This tests was failing on CNL QA

Test list:
igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-gtt
igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-gtt

output sample:
. . .
(kms_frontbuffer_tracking:1585) CRITICAL: Test assertion failure function do_status_assertions, file kms_frontbuffer_tracking.c:1756:
(kms_frontbuffer_tracking:1585) CRITICAL: Failed assertion: !psr_is_enabled()
(kms_frontbuffer_tracking:1585) CRITICAL: PSR still enabled
Subtest fbcpsr-1p-offscren-pri-shrfb-draw-mmap-gtt failed.
. . .

software:
IGT-Version: 1.22-g2ef96ec (x86_64) (Linux: 4.16.0-rc7-drm-tip-ww15-commit-d123888+ x86_64)
Comment 8 James Ausmus 2018-06-19 22:50:48 UTC
Martin - it looks like this is also an "idle run" bug for PSR? How often does it reproduce? (Also, is there an easy way for me to determine that myself? :)  )
Comment 9 Dhinakaran Pandiyan 2018-07-14 21:51:09 UTC
Fix submitted to mailing list
https://patchwork.freedesktop.org/patch/238482/

    tests/frontbuffer_tracking: Use the library functions to test PSR.

    kms_frontbuffer_tracking should test PSR the same way that kms_psr does.

    Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Comment 10 Dhinakaran Pandiyan 2018-07-14 22:37:14 UTC
*** Bug 104466 has been marked as a duplicate of this bug. ***
Comment 11 Dhinakaran Pandiyan 2018-07-14 22:59:34 UTC
(In reply to Dhinakaran Pandiyan from comment #9)
> Fix submitted to mailing list
> https://patchwork.freedesktop.org/patch/238482/
> 
>     tests/frontbuffer_tracking: Use the library functions to test PSR.
> 
>     kms_frontbuffer_tracking should test PSR the same way that kms_psr does.
> 
>     Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>     Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

The patch does the fix this bug, verified adding the relevant test cases to ff list.

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1590/all.html
Comment 12 Lukasz Kalamarz 2018-08-01 12:48:35 UTC
Issue last visible in CI more than 2 weeks ago. Closing this bug.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.