Bug 105512 - Invalid tap event TAP_EVENT_RELEASE in state TAP_STATE_{TAPPED,MULTITAP}
Summary: Invalid tap event TAP_EVENT_RELEASE in state TAP_STATE_{TAPPED,MULTITAP}
Status: RESOLVED MOVED
Alias: None
Product: Wayland
Classification: Unclassified
Component: libinput (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Wayland bug list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-14 21:34 UTC by Vincent Blut
Modified: 2018-06-05 09:59 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
evemu-record capture (146.90 KB, text/plain)
2018-03-21 21:57 UTC, Vincent Blut
Details
udevadm_output (713 bytes, text/plain)
2018-03-21 22:32 UTC, Vincent Blut
Details

Description Vincent Blut 2018-03-14 21:34:35 UTC
Hello,

Libinput 1.10.x branch introduced a regression regarding three-finger click on my Elantech touchpad.
Sporadically, any middle click attempt is ineffective. When that happens, the following errors get logged:

(EE) event1  - ETPS/2 Elantech Touchpad: libinput bug: invalid tap event TAP_EVENT_RELEASE in state TAP_STATE_TAPPED
(EE) event1  - ETPS/2 Elantech Touchpad: libinput bug: invalid tap event TAP_EVENT_RELEASE in state TAP_STATE_MULTITAP

Do you have an idea about what goes wrong?
Comment 1 Peter Hutterer 2018-03-14 22:11:42 UTC
I'll need an evemu-record that triggers that bug please, thanks. You're on 1.10.3?
Comment 2 Vincent Blut 2018-03-14 23:07:22 UTC
(In reply to Peter Hutterer from comment #1)
> I'll need an evemu-record that triggers that bug please, thanks.
Ok, will do as soon as possible.

> You're on 1.10.3?
Indeed.
Comment 3 Vincent Blut 2018-03-21 21:57:59 UTC
Created attachment 138261 [details]
evemu-record capture

Hi Peter,

I finally found the time to record my touchpad’s behavior.
You’ll notice that after each middle-click attempt I slightly move
the cursor; that’s because it tends to be “stuck” for a few milliseconds afterward.

Cheers,
Vincent
Comment 4 Peter Hutterer 2018-03-21 22:16:24 UTC
what's the output of udevadm info /sys/class/input/eventXX for your event node? I can't reproduce the bug here, not even with 1.10.0 so there may be a device-specific udev property that doesn't get applied on the test host.
Comment 5 Vincent Blut 2018-03-21 22:32:30 UTC
Created attachment 138262 [details]
udevadm_output
Comment 6 Peter Hutterer 2018-03-22 01:27:26 UTC
can you reproduce the bug by replaying that event sequence? Still doesn't work for me here, and that's after matching all the udev properties. This doesn't even get into the multitap state, afaict all touches are detected as palms.
Comment 7 Vincent Blut 2018-03-22 13:12:50 UTC
Yup, it seems I’m able to reproduce it, not all the time though. Now that you mention palm events, I just saw that a different error message has been logged yesterday:

(EE) event3  - ETPS/2 Elantech Touchpad: libinput bug: invalid tap event TAP_EVENT_PALM in state TAP_STATE_TAPPED
Comment 8 Peter Hutterer 2018-03-22 23:52:01 UTC
I wonder if that is similar to bug 105160 where the state changes happen within the same EV_SYN frame and thus confuse the state machine. If so, that's going to need *a lot* of tests...
Comment 9 GitLab Migration User 2018-06-05 09:59:57 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/libinput/libinput/issues/15.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.