Created attachment 138852 [details] [review] Fix for piglit The version requirements for GL_ARB_gpu_shader5 are incorrect. I have already fixed this locally, just dont have time for a proper patch right now. Affects two piglit tests, for one I already have a patch the other one seems trickier. Requirements for GL_ARB_gpu_shader5 From https://www.khronos.org/registry/OpenGL/extensions/ARB/ARB_gpu_shader5.txt This extension interacts with ARB_gpu_shader_fp64. This extension interacts with NV_gpu_shader5. This extension interacts with ARB_sample_shading. This extension interacts with ARB_texture_gather. OpenGL 3.2 and GLSL 1.50 are required. From https://www.khronos.org/registry/OpenGL/extensions/NV/NV_gpu_shader5.txt If implemented in OpenGL ES, OpenGL ES 3.1 and GLSL ES 3.10 are required.
Created attachment 138853 [details] [review] patch for Mesa
Just to be clear: this doesnt fix a failing test in piglit. shader-db shows an error when the affected piglit shaders are run. and the version requirements are really wrong ;)
I'm not sure how you created the patch but please setup your name and email in git and use 'git format-patch'. Or even better use 'git send-email' and send the patch directly to the piglit mailing list. Anyway I've fixed things up and pushed the patch. Thanks!
Timothy, do you want to push the corresponding mesa patch as well? I might not get to it until the weekend.
(In reply to ben@besd.de from comment #4) > Timothy, > do you want to push the corresponding mesa patch as well? I might not get to > it until the weekend. hmmm, I though you were fixing the piglit tests to match mesa. I that cause I'm not sure this was right. I believe we don't always follow these version requirements and treat them more as a guideline. You should start sending your patches to the list rather than attaching them to bugs so that other developers can discuss/comment.
(In reply to Timothy Arceri from comment #5) > (In reply to ben@besd.de from comment #4) > > Timothy, > > do you want to push the corresponding mesa patch as well? I might not get to > > it until the weekend. > > hmmm, I though you were fixing the piglit tests to match mesa. I that cause > I'm not sure this was right. > > I believe we don't always follow these version requirements and treat them > more as a guideline. You should start sending your patches to the list > rather than attaching them to bugs so that other developers can > discuss/comment. I guess it's ok, to have piglit follow the version requirements so that the test are guaranteed to work on other implementations, but I'm not sure we need to change Mesa.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.