Bug 106116 - only build GL surface tests if GLX is enabled
Summary: only build GL surface tests if GLX is enabled
Status: RESOLVED MOVED
Alias: None
Product: cairo
Classification: Unclassified
Component: gl backend (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: cairo-bugs mailing list
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-18 07:16 UTC by Michael Olbrich
Modified: 2018-08-25 13:37 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
only build GL surface tests if GLX is enabled (1.14 KB, patch)
2018-04-18 07:16 UTC, Michael Olbrich 		Details | Splinter Review
View All

Description Michael Olbrich 2018-04-18 07:16:11 UTC 
All GL surface tests use GLX. But OpenGL can be enabled without GLX if EGL
ist used, so an additional check is needed.
Comment 1 Michael Olbrich 2018-04-18 07:16:15 UTC 
Created attachment 138896 [details] [review]
only build GL surface tests if GLX is enabled

All GL surface tests use GLX. So with --enable-png (to enable tests in
general) and --enable-gl (for CAIRO_HAS_GL_SURFACE) building fails with:
[...]
gl-surface-source.c:33:5: error: unknown type name 'Display'
gl-surface-source.c:34:5: error: unknown type name 'GLXContext'
[...]
And similar errors for the other tests.

Fix this by making sure the GL surface tests are only built is GLX is
enabled.

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
Comment 2 GitLab Migration User 2018-08-25 13:37:09 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/cairo/cairo/issues/101.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.