Bug 106279 - Support more than just USB devices
Summary: Support more than just USB devices
Status: RESOLVED MOVED
Alias: None
Product: libfprint
Classification: Unclassified
Component: libfprint (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: libfprint-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-27 12:19 UTC by Bastien Nocera
Modified: 2018-05-31 08:56 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
lib: Add new bus types for drivers (62.46 KB, patch)
2018-04-27 12:20 UTC, Bastien Nocera
Details | Splinter Review
lib: Simplify device discovery (2.32 KB, patch)
2018-04-27 12:20 UTC, Bastien Nocera
Details | Splinter Review
lib: Rename USB-specific discovery functions (1.93 KB, patch)
2018-04-27 12:20 UTC, Bastien Nocera
Details | Splinter Review
lib: Add new bus types for drivers (62.46 KB, patch)
2018-04-27 14:05 UTC, Bastien Nocera
Details | Splinter Review
lib: Add new bus types for drivers (62.47 KB, patch)
2018-05-11 09:12 UTC, Bastien Nocera
Details | Splinter Review
lib: Simplify device discovery (2.32 KB, patch)
2018-05-11 09:12 UTC, Bastien Nocera
Details | Splinter Review
lib: Rename USB-specific discovery functions (1.93 KB, patch)
2018-05-11 09:12 UTC, Bastien Nocera
Details | Splinter Review
lib: Rename all instances of "udev" to "usb_dev" (4.87 KB, patch)
2018-05-11 09:12 UTC, Bastien Nocera
Details | Splinter Review

Description Bastien Nocera 2018-04-27 12:19:51 UTC
Preparatory patches here. I don't have access to hardware, but adding udev based device discovery should be pretty straight forward. Note that udev support would need to be optional, as *BSDs use libfprint, and have no udev.
Comment 1 Bastien Nocera 2018-04-27 12:20:40 UTC
Created attachment 139168 [details] [review]
lib: Add new bus types for drivers

Add a way for drivers to declare they support a bus type other than USB.
We have declarations for I2C and virtual drivers, though no discovery is
done just yet.
Comment 2 Bastien Nocera 2018-04-27 12:20:44 UTC
Created attachment 139169 [details] [review]
lib: Simplify device discovery

Use GPtrArray instead of open-coding a NULL terminated array.
Comment 3 Bastien Nocera 2018-04-27 12:20:46 UTC
Created attachment 139170 [details] [review]
lib: Rename USB-specific discovery functions
Comment 4 Bastien Nocera 2018-04-27 14:05:02 UTC
Created attachment 139174 [details] [review]
lib: Add new bus types for drivers

Add a way for drivers to declare they support a bus type other than USB.
We have declarations for SPI and virtual drivers, though no discovery is
done just yet.
Comment 5 Bastien Nocera 2018-05-11 09:12:12 UTC
Created attachment 139492 [details] [review]
lib: Add new bus types for drivers

Add a way for drivers to declare they support a bus type other than USB.
We have declarations for SPI and virtual drivers, though there's no
device discovery implemented yet.
Comment 6 Bastien Nocera 2018-05-11 09:12:15 UTC
Created attachment 139493 [details] [review]
lib: Simplify device discovery

Use GPtrArray instead of open-coding a NULL terminated array.
Comment 7 Bastien Nocera 2018-05-11 09:12:19 UTC
Created attachment 139494 [details] [review]
lib: Rename USB-specific discovery functions
Comment 8 Bastien Nocera 2018-05-11 09:12:22 UTC
Created attachment 139495 [details] [review]
lib: Rename all instances of "udev" to "usb_dev"

Because otherwise it's going to get really confusing when we add
udev-based device discovery.
Comment 9 Bastien Nocera 2018-05-29 11:45:06 UTC
Comment on attachment 139495 [details] [review]
lib: Rename all instances of "udev" to "usb_dev"

The API to access the "udev" is called:
fpi_dev_get_usb_dev()
and
fpi_imgdev_get_usb_dev()
depending on the type of driver.
Comment 10 Bastien Nocera 2018-05-29 11:45:56 UTC
Comment on attachment 139493 [details] [review]
lib: Simplify device discovery

Attachment 139493 [details] pushed as db34837 - lib: Simplify device discovery
Comment 11 GitLab Migration User 2018-05-31 08:56:00 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/libfprint/libfprint/issues/44.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.