Bug 106329 - FindLIBOPENJPEG.cmake checks wrong variable to avoid re-finding library
Summary: FindLIBOPENJPEG.cmake checks wrong variable to avoid re-finding library
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: cpp frontend (show other bugs)
Version: unspecified
Hardware: All All
: medium trivial
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-01 01:38 UTC by Matthew J. P. Walker
Modified: 2018-05-04 13:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
questionably useful patch (400 bytes, text/plain)
2018-05-01 01:38 UTC, Matthew J. P. Walker 		Details
View All

Description Matthew J. P. Walker 2018-05-01 01:38:56 UTC 
Created attachment 139240 [details]
questionably useful patch

It seems that cmake/modules/FindLIBOPENJPEG.cmake checks LIBOPENJPEG2_INCLUDE_DIR but sets LIBOPENJPEG2_INCLUDE_DIRS (note: plural-ness), preventing the cmake cache from working correctly. The check should be one the plural one, I believe.

A pretty trivial fix. I've tried doing the find+replace myself, and nothing went wrong when building xournalpp. I attached a patch for this one-liner, though it may be easier to just apply the change manually...
Comment 1 Albert Astals Cid 2018-05-04 13:50:07 UTC 
actually your patch breaks the build because fixing the if makes that we stop defining USE_OPENJPEG2 :D

Since the cache if has been not working for a long time, i'll just remove it. 

Thanks for the heads up :)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.