Bug 106340 - Missing test cases for palm detection based on touch size
Summary: Missing test cases for palm detection based on touch size
Status: RESOLVED MOVED
Alias: None
Product: Wayland
Classification: Unclassified
Component: libinput (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Wayland bug list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-01 23:44 UTC by Peter Hutterer
Modified: 2018-06-05 10:00 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Hutterer 2018-05-01 23:44:20 UTC
as $SUBJECT
Comment 1 Furkan Tokac 2018-05-28 21:58:51 UTC
(In reply to Peter Hutterer from comment #0)
> as $SUBJECT

This is the *palm* functions in evdev-mt-touchpad.c right ? Also is there any special thing that I need to pay attention for while writing the tests ?
Comment 2 Peter Hutterer 2018-05-28 22:07:25 UTC
have a look at touchpad_palm_detect_touch_size(), it has a basic test for
palm detection. All the touchpad_palm_detect_pressure_* functions are
similar, we need to replicate those with size-based palm detection. Those
pressure tests should be a pretty good blueprint for what we need here, the
actual tests are probably mostly copy/paste here.

Good practice for running the test suite :) make use of
--filter-test=<function name> and --filter-device="*bcm*" toggles to run the
tests quicker.
Comment 3 Furkan Tokac 2018-05-28 22:16:07 UTC
(In reply to Peter Hutterer from comment #2)
> have a look at touchpad_palm_detect_touch_size(), it has a basic test for
> palm detection. All the touchpad_palm_detect_pressure_* functions are
> similar, we need to replicate those with size-based palm detection. Those
> pressure tests should be a pretty good blueprint for what we need here, the
> actual tests are probably mostly copy/paste here.
> 
> Good practice for running the test suite :) make use of
> --filter-test=<function name> and --filter-device="*bcm*" toggles to run the
> tests quicker.

Nice tips thanks. I got the task. Working on it.
I'll disturb you if I have a question :)
Comment 4 GitLab Migration User 2018-06-05 10:00:42 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/libinput/libinput/issues/21.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.