Bug 106602 - [CI] igt@pm_lpsp@edp-panel-fitter - fail - Failed assertion: c->count_modes && c->modes[0].vdisplay > 768
Summary: [CI] igt@pm_lpsp@edp-panel-fitter - fail - Failed assertion: c->count_modes &...
Status: ASSIGNED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: medium normal
Assignee: Matt Roper
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard: ReadyForDev
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-22 05:47 UTC by Martin Peres
Modified: 2019-08-29 17:19 UTC (History)
1 user (show)

See Also:
i915 platform: HSW
i915 features: display/eDP


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Peres 2018-05-22 05:47:52 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_31/fi-hsw-peppy/igt@pm_lpsp@edp-panel-fitter.html

(pm_lpsp:2487) CRITICAL: Test assertion failure function edp_subtest, file ../tests/pm_lpsp.c:115:
(pm_lpsp:2487) CRITICAL: Failed assertion: c->count_modes && c->modes[0].vdisplay > 768
Subtest edp-panel-fitter failed.
Comment 1 CI Bug Log 2019-02-08 15:34:32 UTC
A CI Bug Log filter associated to this bug has been updated:

{- fi-hsw-peppy: igt@pm_lpsp@edp-panel-fitter - fail - Failed assertion: c->count_modes && c->modes[0].vdisplay > 768 -}
{+ fi-hsw-peppy: igt@pm_lpsp@edp-panel-fitter - fail/dmesg-fail - Failed assertion: c->count_modes && c->modes[0].vdisplay > 768 +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_212/fi-hsw-peppy/igt@pm_lpsp@edp-panel-fitter.html
Comment 2 CI Bug Log 2019-02-08 15:36:38 UTC
A CI Bug Log filter associated to this bug has been updated:

{- fi-hsw-peppy: igt@pm_lpsp@edp-panel-fitter - fail/dmesg-fail - Failed assertion: c->count_modes && c->modes[0].vdisplay > 768 -}
{+ fi-hsw-peppy: igt@pm_lpsp@edp-panel-fitter - fail/dmesg-fail - Failed assertion: c->count_modes && c->modes[0].vdisplay > 768 +}

 No new failures caught with the new filter
Comment 3 CI Bug Log 2019-02-08 15:37:36 UTC
The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* HSW:  IGT: igt@runner@aborted - fail - Previous test: pm_lpsp (edp-panel-fitter)
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_212/fi-hsw-peppy/igt@runner@aborted.html
Comment 4 CI Bug Log 2019-02-28 15:14:53 UTC
A CI Bug Log filter associated to this bug has been updated:

{- HSW:  IGT: igt@runner@aborted - fail - Previous test: pm_lpsp (edp-panel-fitter) -}
{+ HSW:  IGT: igt@runner@aborted - fail -Previous test: pm_lpsp/i915_pm_lpsp +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_232/fi-hsw-peppy/igt@runner@aborted.html
Comment 5 Matt Roper 2019-08-29 17:19:33 UTC
This failure looks like an issue with the test program.  The problematic code is this section:

   /* This is one of the modes Xorg creates for panels, so
    * it should work just fine. Notice that Gens that
    * support LPSP are too new for panels with native
    * 1024x768 resolution, so this should force the panel
    * fitter. */
   igt_assert(c->count_modes &&
              c->modes[0].hdisplay > 1024);
   igt_assert(c->count_modes &&
              c->modes[0].vdisplay > 768);
   mode = &std_1024_mode;

There are a few problems here:
 * The platform being tested here has a 13x7 panel which fails the second assert above, even though the panel fitter would still have been used.  We should check hdisplay and vdisplay together to avoid this.
 * If we do come across a true 1024x768 panel on a platform with LPSP we should be skipping this test, not marking it as a failure.  I.e., igt_require() rather than igt_assert().

I think this patch should fix the failure:
https://patchwork.freedesktop.org/series/66015/


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.